#574 FIX

[TikhomirovSergey]

Change list

• wait.until(ExpectedConditions.visibilityOf(elementName)) related issue #574 BUG FIX;
• Some codestyle improvements;

Types of changes

• No changes in production code.
• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

@vikramvi I could find the rootcause of the bug.
Here: https://github.com/SeleniumHQ/selenium/blob/master/java/client/src/org/openqa/selenium/support/ui/ExpectedConditions.java#L293

the toString() method is invoked. And this method is overriden by RemoteWebElement. So the searching was being invoked... twice :)))

Now this sample test passes:

packageio.appium.java_client.pagefactory_tests;
importio.appium.java_client.android.BaseAndroidTest;
importio.appium.java_client.pagefactory.AndroidFindBy;
importio.appium.java_client.pagefactory.AppiumFieldDecorator;
importio.appium.java_client.pagefactory.WithTimeout;
importorg.junit.Assert;
importorg.junit.Before;
importorg.junit.Test;
importorg.openqa.selenium.WebElement;
importorg.openqa.selenium.support.PageFactory;
importorg.openqa.selenium.support.ui.ExpectedConditions;
importorg.openqa.selenium.support.ui.WebDriverWait;
importjava.util.Calendar;
importjava.util.concurrent.TimeUnit;
importstaticorg.junit.Assert.assertTrue;
publicclassBugReproducingextendsBaseAndroidTest {
privatestaticfinallongACCEPTABLE_DELTA_MILLS = 1500;
@WithTimeout(time = 4, unit = TimeUnit.SECONDS)
@AndroidFindBy(className = "ABC") //this is invalid locator; purposely put upprivateWebElementtextView;
/** * The setting up. */@BeforepublicvoidsetUp() throwsException {
PageFactory.initElements(newAppiumFieldDecorator(driver, 15, TimeUnit.SECONDS), this);
}
publicbooleanisElementPresent(WebElementelementName, inttimeout){
try{
WebDriverWaitwait = newWebDriverWait(driver, timeout);
wait.until(ExpectedConditions.visibilityOf(elementName));
returntrue;
}catch(Exceptione){
returnfalse;
}
}
privatestaticbooleancheckTimeDifference(longexpectedTime, TimeUnitexpectedTimeUnit,
longcurrentMillis) {
longexpectedMillis = TimeUnit.MILLISECONDS.convert(expectedTime, expectedTimeUnit);
try {
Assert.assertEquals(true,
((currentMillis - expectedMillis) < ACCEPTABLE_DELTA_MILLS) && (
(currentMillis - expectedMillis) >= 0));
} catch (Errore) {
Stringmessage = String.valueOf(expectedTime) + " "
+ expectedTimeUnit.toString()
+ " current duration in millis "
+ String.valueOf(currentMillis) + " Failed";
thrownewAssertionError(message, e);
}
returntrue;
}
@TestpublicvoidfindByElementTest() {
longstartMark = Calendar.getInstance().getTimeInMillis();
isElementPresent(textView,2);
/*try { textView.isDisplayed(); } catch (Exception e) { e.printStackTrace(); }*/longendMark = Calendar.getInstance().getTimeInMillis();
assertTrue(checkTimeDifference(4,
TimeUnit.SECONDS, endMark - startMark));
}
}

[TikhomirovSergey]

@vikramvi@SrinivasanTarget Could you review this PR.

[TikhomirovSergey]

...I should say that the similar bug is contained by common Selenium tools.

[saikrishna321]

Non invited PR review 😉 looks good to me.. Tested and works fine 👍

[SrinivasanTarget]

cool @saikrishna321 👍

[SrinivasanTarget]

Awesome 👍

[TikhomirovSergey]

ok. I'm merging.