#764 alternative fix by TikhomirovSergey · Pull Request #769 · appium/java-client

TikhomirovSergey · 2017-11-17T22:24:20Z

Change list

#764 FIX. This change was made according to the confersation #765

Types of changes

No changes in production code.
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

The asking for the current platform was optimized.

The asking for the browser or not was optimized.

Also: - WidgetListInterceptor was optimized - some code style improvements

TikhomirovSergey · 2017-11-17T22:26:20Z

@vrunoa You can review it too. It would be cool if you could try to test this change on your environment.

mykola-mokhnach · 2017-11-18T07:02:51Z

- ElementMap element = Optional.ofNullable(mobileElementMap.get(String
- .valueOf(hasSessionDetails.getAutomationName()).toLowerCase().trim()))
+ ElementMap element = Optional.ofNullable(mobileElementMap.get(
+String.valueOf(platform).toLowerCase().trim()))


does it make any sense to use String.valueOf for values of type String?

@mykola-mokhnach It may return null value

mykola-mokhnach · 2017-11-18T07:03:45Z


+ private static By getBy(By currentBy, SearchContext currentContent) {
+ if (!ContentMappedBy.class.isAssignableFrom(currentBy.getClass())) {
+ return currentBy;


it might be easier to understand the code if this condition had an explanation comment

mykola-mokhnach · 2017-11-18T07:04:16Z

- List<WebElement> list = searchContext.findElements(by);
+ List<WebElement> list = searchContext
+ .findElements(getBy(by, searchContext));
 if (list.size() > 0) {


return list.size() > 0 ? list : null

mykola-mokhnach · 2017-11-18T07:05:03Z

- || !HasSessionDetails.class.isAssignableFrom(originalDriver.getClass())) {
- hasSessionDetails = null;
+ HasSessionDetails hasSessionDetails = ofNullable(this.originalDriver).map(webDriver -> {
+ if (!HasSessionDetails.class.isAssignableFrom(originalDriver.getClass())) {


originalDriver -> webDriver

mykola-mokhnach · 2017-11-18T07:08:14Z

+
 @Override public WebElement findElement(SearchContext context) {
- return context.findElement(map.get(getCurrentContentType(context)));
+ return context.findElement(map.get(currentContent));


is it ok if map.get returns null in any of these methods?

It is not possible. It will use NATIVE_MOBILE_SPECIFIC as it is defined by default or it will use HTML_OR_DEFAULT when there is no SearchContext which also implements ContextArare or HasSessionDetails. Also it will use HTML_OR_DEFAULT when HasSessionDetails.isBrowser returns true or current context != NATIVE_CONTEXT.
Also there is the method
/** * This method sets required content type for the further searching. * @param type required content type {@link ContentType} * @return self-reference. */publicByuseContent(@NonnullContentTypetype) { checkNotNull(type); currentContent = type; returnthis; }

mykola-mokhnach

LGTM, just minor comments

TikhomirovSergey · 2017-11-18T21:14:03Z

@mykola-mokhnach I have improved some things that you pointed.
@SrinivasanTarget I am waining for your review.

SrinivasanTarget

👍

SrinivasanTarget · 2017-11-19T06:45:52Z

LGTM

mykola-mokhnach · 2017-11-19T07:20:07Z

- HasSessionDetails hasSessionDetails = ofNullable(this.originalDriver).map(webDriver -> {
- if (!HasSessionDetails.class.isAssignableFrom(originalDriver.getClass())) {
+ this.webDriver = unpackWebDriverFromSearchContext(context);
+ HasSessionDetails hasSessionDetails = ofNullable(this.webDriver).map(webDriver -> {


I meant it's better to use the mapped local variable webDriver -> inside the lambda handler rather than class-level this.originalDriverone.

TikhomirovSergey · 2017-11-19T19:23:10Z

@vrunoa
Also it is interesting to know about the time. Was it increased or reduced with this change on your environment? I will wait for a day or two days.

vrunoa · 2017-11-20T00:24:57Z

@TikhomirovSergey i'm running tests, i'll get back to you as soon as I have some results.

TikhomirovSergey · 2017-11-20T13:40:28Z

@vrunoa and what the result?

TikhomirovSergey · 2017-11-21T09:16:38Z

ping @vrunoa

vrunoa · 2017-11-21T12:07:43Z

@TikhomirovSergey sorry for the delay. I'm session a lot less getSession calls and test times got reduced. Lets merge it.

TikhomirovSergey · 2017-11-21T13:20:49Z

@vrunoa How much time was reduced? I will merge it later today

vrunoa · 2017-11-21T13:30:16Z

@TikhomirovSergey from 2hs to 50minutes approximately.

SrinivasanTarget · 2017-11-21T15:52:12Z

2hs to 50minutes approximately

Awesome

TikhomirovSergey added 4 commits November 15, 2017 00:09

#764FIX.
2ddb61c
The asking for the current platform was optimized.

#764FIX. AppiumFieldDecorator. Code style improvement
60b2aa9

#764FIX.
e75a8a5
The asking for the browser or not was optimized.

#764FIX: DefaultGenericMobileDriver: toString method was changed
a19c0de
Also: - WidgetListInterceptor was optimized - some code style improvements

TikhomirovSergey added bug refactor labels Nov 17, 2017

TikhomirovSergey self-assigned this Nov 17, 2017

TikhomirovSergey requested review from SrinivasanTarget and mykola-mokhnach November 17, 2017 22:24

mykola-mokhnach reviewed Nov 18, 2017
View reviewed changes

mykola-mokhnach approved these changes Nov 18, 2017
View reviewed changes

mykola-mokhnach mentioned this pull request Nov 18, 2017
Cache session details to avoid making unnecessary queries #765
Closed
4 tasks

#764FIX: improving of some minor issues.
b784e16

appium deleted a comment Nov 19, 2017

SrinivasanTarget approved these changes Nov 19, 2017
View reviewed changes

mykola-mokhnach reviewed Nov 19, 2017
View reviewed changes

#764FIX: improving of some minor issues.
d10f5d1

appium deleted a comment Nov 19, 2017

TikhomirovSergey merged commit dd8f33e into appium:masterNov 21, 2017

KazuCocoa mentioned this pull request Jun 20, 2018
Appium 1.8+ is brutally slow using Geb and Spock framework on iOS because AppiumDriver.getSession() became slow appium/appium#10790
Closed

Uh oh!

Uh oh!

Conversation

TikhomirovSergey commented Nov 17, 2017

Change list

Types of changes

Uh oh!

TikhomirovSergey commented Nov 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mykola-mokhnach left a comment

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergey commented Nov 18, 2017

Uh oh!

SrinivasanTarget left a comment

Choose a reason for hiding this comment

Uh oh!

SrinivasanTarget commented Nov 19, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergey commented Nov 19, 2017

Uh oh!

vrunoa commented Nov 20, 2017

Uh oh!

TikhomirovSergey commented Nov 20, 2017

Uh oh!

TikhomirovSergey commented Nov 21, 2017

Uh oh!

vrunoa commented Nov 21, 2017

Uh oh!

TikhomirovSergey commented Nov 21, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vrunoa commented Nov 21, 2017

Uh oh!

SrinivasanTarget commented Nov 21, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TikhomirovSergey commented Nov 21, 2017•
edited
Loading