Additional changes of the #473 by TikhomirovSergey · Pull Request #786 · appium/java-client

TikhomirovSergey · 2017-12-11T19:57:15Z

Change list

Additional changes of the #473

Types of changes

No changes in production code.
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

AuthenticatesByFinger was added to io.appium.java_client.android
Some improvements of the FingerPrintTest

into alizelzele-finger-print

- AuthenticatesByFinger was added to `io.appium.java_client.android` - Some improvements of the FingerPrintTest

TikhomirovSergey · 2017-12-11T19:58:18Z

@alizelzele You can take a look at this PR and review it too.

mykola-mokhnach · 2017-12-11T20:33:14Z

+ service = AppiumDriverLocalService.buildDefaultService();
+ service.start();
+
+ if (service == null || !service.isRunning()) {


service cannot be null here

@mykola-mokhnach it was copied from BaseAndroidTest and for sure it can not be null here :)

mykola-mokhnach · 2017-12-11T20:34:41Z

+ enterPasswordAndContinue(driver);
+ enterPasswordAndContinue(driver);
+ clickNext(driver);
+ driver.quit();


I'd rather move driver create/quit into before/after each method

SrinivasanTarget

@TikhomirovSergey I always get errors irrespective of API levels (23,25, 26) & UIA1/UIA2.
https://gist.github.com/SrinivasanTarget/416e82b0f13db0b237cc92a23a85cbf6

mykola-mokhnach · 2017-12-12T16:34:58Z

@SrinivasanTarget Did you try to grant app permissions in capabilities?

SrinivasanTarget · 2017-12-12T16:43:22Z

@mykola-mokhnach I tried with AutoGrantPermissions Caps and output is same on both UIA1/UIA2. Is it the same caps you are talking about?

TikhomirovSergey · 2017-12-12T20:44:46Z

@SrinivasanTarget Everything is ok for me.
https://gist.github.com/TikhomirovSergey/5d389ed79c8433c524825f2aa5ffe2b1

Could you try such emulator

@mykola-mokhnach I am going to make some changes soon.

SrinivasanTarget · 2017-12-13T17:06:03Z

@TikhomirovSergey It works with above config. But not in API 25 & 26.

alizelzele · 2017-12-14T03:42:18Z

@SrinivasanTarget since we are not using any test app and android changed its settings implementation on different APIs. I didn't find any other way to implement this test.

TikhomirovSergey · 2017-12-15T22:37:48Z

@alizelzele @mykola-mokhnach @SrinivasanTarget
It seems I found a way to make the test stable. Will update this PR on this weekend

TikhomirovSergey · 2017-12-16T23:59:20Z

@SrinivasanTarget Could you try to run the test with the latest change. It seems I made it working.
@mykola-mokhnach The test was re-designed.

SrinivasanTarget · 2017-12-17T02:48:55Z

 driver.fingerPrint(2);
 try {
-clickNext(driver);
+ driver.findElementById("com.android.settings:id/next_button").click();


Should be clickNext()

Yes. Will improve today.

alizelzele · 2017-12-17T09:29:49Z

+ text.equals(androidElement.getText())).findFirst()
+ .orElseThrow(() ->
+ new NoSuchElementException(String.format("There is no element with the text '%s'", text)));
+ }


I was so used to localization testing that my mind automatically blocked using text to find an element :)
using text is much better and easier in this case 👍

TikhomirovSergey · 2017-12-17T17:29:12Z

@SrinivasanTarget The improvement has been done

SrinivasanTarget

Looks good now

TikhomirovSergey · 2017-12-18T07:36:32Z

@SrinivasanTarget Is the test stable on your environment?

SrinivasanTarget · 2017-12-18T07:39:02Z

Yes @TikhomirovSergey

alizelzele · 2017-12-19T05:46:12Z

yeaaayyy, finally 🎉

alizelzeleand others added 3 commits December 2, 2017 17:13

add finger print command to android Driver
c8946c1

Merge branch 'finger-print' ofhttps://github.com/alizelzele/java-client
48d703c
into alizelzele-finger-print

Additional changes of the#473:
0a3f463
- AuthenticatesByFinger was added to `io.appium.java_client.android` - Some improvements of the FingerPrintTest

TikhomirovSergey requested review from SrinivasanTarget and mykola-mokhnach December 11, 2017 19:57

TikhomirovSergey added the Android label Dec 11, 2017

mykola-mokhnach reviewed Dec 11, 2017
View reviewed changes

SrinivasanTarget reviewed Dec 12, 2017
View reviewed changes

Additional changes of the#473: improvements of FingerPrintTest
2585bba

SrinivasanTarget reviewed Dec 17, 2017
View reviewed changes

alizelzele reviewed Dec 17, 2017
View reviewed changes

Additional changes of the#473: improvements of FingerPrintTest
eb4116f

SrinivasanTarget approved these changes Dec 18, 2017
View reviewed changes

TikhomirovSergey merged commit e37f4e4 into appium:masterDec 18, 2017

Uh oh!

Uh oh!

Conversation

TikhomirovSergey commented Dec 11, 2017

Change list

Types of changes

Details

Uh oh!

TikhomirovSergey commented Dec 11, 2017

Uh oh!

mykola-mokhnachDec 11, 2017

Choose a reason for hiding this comment

Uh oh!

alizelzeleDec 14, 2017

Choose a reason for hiding this comment

Uh oh!

mykola-mokhnachDec 11, 2017

Choose a reason for hiding this comment

Uh oh!

SrinivasanTarget left a comment

Choose a reason for hiding this comment

Uh oh!

mykola-mokhnach commented Dec 12, 2017

Uh oh!

SrinivasanTarget commented Dec 12, 2017

Uh oh!

TikhomirovSergey commented Dec 12, 2017

Uh oh!

SrinivasanTarget commented Dec 13, 2017

Uh oh!

alizelzele commented Dec 14, 2017

Uh oh!

TikhomirovSergey commented Dec 15, 2017

Uh oh!

TikhomirovSergey commented Dec 16, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SrinivasanTargetDec 17, 2017

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergeyDec 17, 2017

Choose a reason for hiding this comment

Uh oh!

alizelzeleDec 17, 2017

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergey commented Dec 17, 2017

Uh oh!

SrinivasanTarget left a comment

Choose a reason for hiding this comment

Uh oh!

TikhomirovSergey commented Dec 18, 2017

Uh oh!

SrinivasanTarget commented Dec 18, 2017

Uh oh!

alizelzele commented Dec 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TikhomirovSergey commented Dec 16, 2017•
edited
Loading