Uh oh!
There was an error while loading. Please reload this page.
Add clipboard handlers - #855
Merged
Merged
Conversation
mykola-mokhnach
commented
Mar 28, 2018
ContributorAuthor
@KazuCocoa FYI |
SrinivasanTarget
requested changes
Mar 28, 2018
| */ | ||
| default void setClipboardUrl(URL url) { | ||
| setClipboard(ClipboardContentType.URL, Base64 | ||
| .getEncoder() |
There was a problem hiding this comment.
getURLEncoder() & getURLDecoder() should be good than basic encoding/decoding as it is not URL safe. Also for text encoding, i would recommend to use MIME encoding over basic encoding. what say @mykola-mokhnach ?
ContributorAuthor
There was a problem hiding this comment.
It looks like this is not the case for Apple's NSData class, since it requires the data to be always padded: https://stackoverflow.com/questions/21406482/nsdata-wont-accept-valid-base64-encoded-string
SrinivasanTarget
commented
Mar 28, 2018
Member
waiting for drivers to get published. will play around after that. |
TikhomirovSergey
commented
Mar 30, 2018
Contributor
@mykola-mokhnach Will review today |
SrinivasanTarget
approved these changes
Apr 8, 2018
SrinivasanTarget
left a comment
Member
There was a problem hiding this comment.
works well on both iOS and android.
SrinivasanTarget
commented
Apr 8, 2018
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
this adds possibility to set and get clipboard content for Android and iOS
Types of changes