Uh oh!
There was an error while loading. Please reload this page.
Fix null request bodies for PUT requests - #281
Open
ferid333 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes null request bodies for
PUTrequests by sending an empty request body instead of passingnullto OkHttp.Problem
While reading through the request-building code, I noticed that
POSTrequests with a null body were already converted to an empty byte array before building the OkHttp request. However,PUTrequests were not handled thesame way.
When a
PUTendpoint is called with a null request object, the client can call:Expected Behavior
The client should build a valid PUT request with a zero-length request body, matching the existing behavior for null-body POST requests.
Changes