Uh oh!
There was an error while loading. Please reload this page.
Fix: Environment variables can be duplicated on run - #1218
Merged
Conversation
simone-panico
marked this pull request as ready for review
February 14, 2026 21:34
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
JaewonHur
approved these changes
Feb 19, 2026
katiewasnothere
approved these changes
Feb 19, 2026
JaewonHur
commented
Feb 19, 2026
Contributor
@simone-panico Could you run |
JaewonHur
approved these changes
Feb 20, 2026
katiewasnothere
approved these changes
Feb 21, 2026
Uh oh!
There was an error while loading. Please reload this page.
jianliang00 pushed a commit
to jianliang00/container
that referenced
this pull request
Aug 28, 2026
## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation update ## Motivation and Context As reported in [1212](apple#1212), environment variables defined in a Dockerfile (ENV) were not being overridden when passed via -e at runtime, resulting in duplicate entries in the container's environment. **Root cause:** `Parser.allEnv()` simply merged image, env-file, and user-provided environment variables without deduplication. Since `getenv()` returns the first match, the image default took precedence over the user override. **Fix:** `allEnv()` now deduplicates by key, with later sources overriding earlier ones ## Testing - [x] Tested locally - [x] Added/updated tests - [ ] Added/updated docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
As reported in 1212, environment variables defined in a Dockerfile (ENV) were not being overridden when passed via -e at runtime, resulting in duplicate entries in the container's environment.
Root cause:
Parser.allEnv()simply merged image, env-file, and user-provided environment variables without deduplication. Sincegetenv()returns the first match, the image default took precedence over the user override.Fix:
allEnv()now deduplicates by key, with later sources overriding earlier onesTesting