Uh oh!
There was an error while loading. Please reload this page.
Add container volume cp - #963
Conversation
9e76056 to
8556a39Compare29976e3 to
37b9999Compare37b9999 to
b940772Compare3e03971 to
e83d9b9CompareSigned-off-by: Karan <karanlokchandani@protonmail.com>
e83d9b9 to
7b76fbeCompareThere was a problem hiding this comment.
Hi @PhantomInTheWire, sorry that it took a while to get to this one.
See the comment here regarding container cp. The same problem applies to a command like container volume cp.
What you have right now isn't copying into the volume. A volume is a sparse disk image file with an ext4 filesystem written inside it. From what I can tell, your code is copying files around the host (it doesn't build for me as the Archive type isn't found).
To copy in and out of a volume we'd need for the volume to not be used in a running container, and then we'd need to launch a utility container that mounts the volume, and then copy from host to the utility container using the equivalent of container cp.
What could be possible is to add a --from to the container volume create command that allows the user to initialize a new named volume using data on their host.
Supports Docker Compose cp - archive streams for stdin-to-service and service-to-stdout copies by staging tar streams through the compose layer and existing Apple path-copy APIs. Pins stephenlclarke/containerization@79b675d so the runtime carries the apple/container#1927 copy lifecycle regression coverage from apple/containerization#799. Upstream scan found no direct Docker Compose copy-stream PR to import; adjacent Apple work reviewed: apple/container#963, apple/containerization#652, apple/container#1832, apple/container#1905. Release-Highlight: Support Docker Compose cp - archive streams for stdin-to-service and service-to-stdout copies; includes apple/container#1927 copy lifecycle fix via apple/containerization#799.
Type of Change
Motivation and Context
related issue: #895
Testing