Uh oh!
There was an error while loading. Please reload this page.
Add support for reading env from named pipes - #964
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Bortnyak
commented
Dec 17, 2025
@dcantah Thank you for the review. I've added the requested changes. Please take a look. |
Uh oh!
There was an error while loading. Please reload this page.
This LGTM, but I'd like an integration test for this (e.g. try and spawn a container doing what's in the issue and verifying it works). Can be added to TestCLIRunCommand.swift |
f791aa8 to
5d66f3cComparedcantah
commented
Dec 19, 2025
You'll need to |
d6bee3c to
f0b8e3eCompare
Done |
dcantah
commented
Dec 19, 2025
@Bortnyak Still says some of these don't have signatures. Can you try squashing your commits down to one, signing that, and then pushing? |
cfefe25 to
c793d59Comparec793d59 to
e35ed8aCompare@Bortnyak I think the rebase was screwed up a bit, there's 32 files changed. Unrelated, but it also seems whatever email you're using for the commits is not assigned to your github account. |
Bortnyak
commented
Dec 19, 2025
dcantah
commented
Dec 19, 2025
Fixed via #974 |
Type of Change
Motivation and Context
This is a fix for issue#956
FileManager.default.contents(atPath:)returnsnilfor named pipes (FIFOs)and process substitutions like
/dev/fd/XXbecause:Solution
Use
FileHandle(forReadingFrom:)instead, which:References
Testing
Result