Skip to content

Remove a double-counted offset in large files - #597

Merged
katiewasnothere merged 1 commit into
apple:mainfrom
dkovba:offset
Mar 30, 2026
Merged

Remove a double-counted offset in large files#597
katiewasnothere merged 1 commit into
apple:mainfrom
dkovba:offset

Conversation

@dkovba

@dkovbadkovba commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Removes a double-counted offset in large files.

Inside fillExtents(), offset is already added to extentStart in extentBlock - no need to have it in start:

 let extentBlock: UInt32 = offset + i * EXT4.MaxBlocksPerExtent
let extentStart: UInt32 = start + extentBlock

This is the same fix as was suggested previously in #462.

@dkovba
dkovba requested a review from dcantahMarch 24, 2026 01:53
@katiewasnothere
katiewasnothere merged commit bed3705 into apple:mainMar 30, 2026
3 checks passed
@dkovba
dkovba deleted the offset branch March 30, 2026 16:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katiewasnotherekatiewasnotherekatiewasnothere approved these changes
@dcantahdcantahAwaiting requested review from dcantah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkovba@katiewasnothere