Skip to content

EXT4: Fix the construction of the path - #666

Merged
wlan0 merged 6 commits into
apple:mainfrom
dkovba:path
Apr 9, 2026
Merged

EXT4: Fix the construction of the path#666
wlan0 merged 6 commits into
apple:mainfrom
dkovba:path

Conversation

@dkovba

@dkovbadkovba commented Apr 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes the construction of the path and removed unnecessary code. Fixes the added failing test:

✘ Test fileTreeNodePathWithAbsoluteRoot() recorded an issue at TestEXT4Reader+IO.swift:600:9: Expectation failed: (dirPtr.pointee.path → /) == (FilePath("/dir") → /dir)
✘ Test fileTreeNodePathWithAbsoluteRoot() recorded an issue at TestEXT4Reader+IO.swift:601:9: Expectation failed: (filePtr.pointee.path → /) == (FilePath("/dir/file") → /dir/file)
✘ Test fileTreeNodePathWithAbsoluteRoot() failed after 0.001 seconds with 2 issues.

@dkovba
dkovba requested a review from wlan0April 8, 2026 20:56
@dcantahdcantah changed the title Fix the construction of the pathEXT4: Fix the construction of the pathApr 8, 2026
@wlan0
wlan0 merged commit 340c31d into apple:mainApr 9, 2026
4 checks passed
@dkovba
dkovba deleted the path branch April 9, 2026 18:57
@iabdullah215iabdullah215 mentioned this pull request Aug 24, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@wlan0wlan0wlan0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkovba@wlan0