You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dependabot #43(archiver 7.0.1→8.0.0)がpeer依存の問題ではなく、v8でAPIが再設計されたことによる実行時エラーで失敗していた(SyntaxError: The requested module 'archiver' does not provide an export named 'default')ため一旦クローズしていた。今回、コードを追従させて改めて対応する。
変更内容
import archiver from 'archiver' + archiver.create('zip', {}) → import { ZipArchive } from 'archiver' + new ZipArchive({})
package.json の archiver を ^8.0.0 に更新
動作確認
npm run package でリリース用zipの生成が成功することを確認
生成された zip のバイト数・ファイル数が旧実装(v7)と同等であることを確認(418ファイル、約2.98MB)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Dependabot #43(archiver 7.0.1→8.0.0)がpeer依存の問題ではなく、v8でAPIが再設計されたことによる実行時エラーで失敗していた(
SyntaxError: The requested module 'archiver' does not provide an export named 'default')ため一旦クローズしていた。今回、コードを追従させて改めて対応する。変更内容
import archiver from 'archiver'+archiver.create('zip', {})→import { ZipArchive } from 'archiver'+new ZipArchive({})package.jsonのarchiverを^8.0.0に更新動作確認
npm run packageでリリース用zipの生成が成功することを確認