Skip to content

Use a cover image instead of just the logo for visilbilty in dark mode - #73

Merged
christyjacob4 merged 1 commit into
mainfrom
fix-logo
Sep 28, 2023
Merged

Use a cover image instead of just the logo for visilbilty in dark mode#73
christyjacob4 merged 1 commit into
mainfrom
fix-logo

Conversation

@stnguyen90

@stnguyen90stnguyen90 commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Use a cover image instead of just the logo for visilbilty in dark mode

Test Plan

Manually modified the HTML to test:

image

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

Comment threadprofile/README.md Outdated
<br />
<p align="center">
<a href="https://appwrite.io" target="_blank"><img width="260" height="39" src="https://appwrite.io/images/logos/appwrite-light.svg" alt="Appwrite Logo"></a>
<a href="https://appwrite.io" target="_blank"><img src="./images/cover.png" alt="Appwrite Logo"></a>

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how GitHub will handle this relative link on the profile page even after reading the docs...

Also move the Console screenshot down so it's not so close to the top
banner.
@christyjacob4
christyjacob4 merged commit 247474d into mainSep 28, 2023
@stnguyen90stnguyen90 mentioned this pull request Sep 28, 2023
@stnguyen90
stnguyen90 deleted the fix-logo branch September 28, 2023 19:37
This was referenced Oct 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stnguyen90@christyjacob4