Skip to content

Extracting function event validator to its own class. - #6219

Merged
abnegate merged 2 commits into
appwrite:masterfrom
byawitz:fix-functions-event
Sep 13, 2023
Merged

Extracting function event validator to its own class.#6219
abnegate merged 2 commits into
appwrite:masterfrom
byawitz:fix-functions-event

Conversation

@byawitz

@byawitzbyawitz commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Closes#6218

Test Plan

  1. Added FunctionEventValidatorTest.php which is the same as EventValidatorTest.php except that any event that starts with functions. will return false.
  2. Tested it on a temporary local Appwrite instance, and I was able to add the functions.* events to a webhook but not to a function.

Related PRs and Issues

#6218

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please also uncomment the functions test in the event validator unit test?

@byawitz

Copy link
Copy Markdown
ContributorAuthor

Done

@abnegate
abnegate merged commit 6be6a96 into appwrite:masterSep 13, 2023
@christyjacob4christyjacob4 mentioned this pull request Sep 14, 2023
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Can't set function event to trigger Webhook

3 participants

@byawitz@stnguyen90@abnegate