Skip to content

fix: trigger create user event - #8718

Merged
christyjacob4 merged 27 commits into
1.6.xfrom
fix-oauth-trigger-create-user-event
Nov 5, 2024
Merged

fix: trigger create user event#8718
christyjacob4 merged 27 commits into
1.6.xfrom
fix-oauth-trigger-create-user-event

Conversation

@loks0n

@loks0nloks0n commented Sep 25, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#2406

Moves users.[userId].create event triggering to a database listener.

This fixes several endpoints that create a user, but didn't previously trigger the event.

@github-actions

github-actionsBot commented Sep 25, 2024•
edited
Loading

Copy link
Copy Markdown

Security Scan Results for PR

Docker Image Scan Results

PackageVersionVulnerabilitySeverity
libecpg16.3-r0CVE-2024-7348HIGH
libecpg-dev16.3-r0CVE-2024-7348HIGH
libpq16.3-r0CVE-2024-7348HIGH
libpq-dev16.3-r0CVE-2024-7348HIGH
postgresql16-dev16.3-r0CVE-2024-7348HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

Meldiron
Meldiron reviewed Sep 25, 2024
View reviewed changes
Comment threadapp/controllers/api/account.php Outdated
Meldiron
Meldiron reviewed Sep 25, 2024
View reviewed changes
Comment threadapp/controllers/api/account.php Outdated
@github-actions

github-actionsBot commented Sep 25, 2024•
edited
Loading

Copy link
Copy Markdown

✨ Benchmark results

  • Requests per second: 1,229
  • Requests with 200 status code: 221,339
  • P99 latency: 0.084920529

⚡ Benchmark Comparison

MetricThis PRLatest version
RPS1,2292,028
200221,339365,062
P990.0849205290.075353955

@loks0n

loks0n commented Sep 25, 2024

Copy link
Copy Markdown
MemberAuthor

fixes: #2406

stnguyen90
stnguyen90 reviewed Sep 25, 2024
View reviewed changes
Comment threadapp/controllers/api/account.php Outdated
@loks0nloks0n self-assigned this Oct 29, 2024
@loks0nloks0n added the product / auth Fixes and upgrades for the Appwrite Auth / Users / Teams services. label Oct 29, 2024
@loks0n
loks0n changed the base branch from main to 1.6.xOctober 29, 2024 12:16
@loks0nloks0n changed the title fix: oauth trigger create user eventfix: trigger create user eventOct 29, 2024
christyjacob4
christyjacob4 reviewed Oct 31, 2024
View reviewed changes
Comment threadapp/controllers/shared/api.php Outdated
christyjacob4
christyjacob4 reviewed Oct 31, 2024
View reviewed changes
Comment threadsrc/Appwrite/Event/Event.php Outdated
@christyjacob4
christyjacob4 merged commit 51274ba into 1.6.xNov 5, 2024
@christyjacob4
christyjacob4 deleted the fix-oauth-trigger-create-user-event branch November 5, 2024 18:40
This was referenced Nov 12, 2024
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christyjacob4christyjacob4christyjacob4 approved these changes
@stnguyen90stnguyen90Awaiting requested review from stnguyen90
@MeldironMeldironAwaiting requested review from Meldiron

Assignees

@loks0nloks0n

Labels

product / authFixes and upgrades for the Appwrite Auth / Users / Teams services.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: accounts.create does not get trigger function on account created with OAuth provider

4 participants

@loks0n@stnguyen90@Meldiron@christyjacob4