Skip to content

Update contributing guide for dev server - #219

Merged
TorstenDittmann merged 1 commit into
mainfrom
feat-contributing-steps
Jan 27, 2023
Merged

Update contributing guide for dev server#219
TorstenDittmann merged 1 commit into
mainfrom
feat-contributing-steps

Conversation

@stnguyen90

Copy link
Copy Markdown
Contributor

What does this PR do?

Add step for creating .env file because without the file, npm run dev results in:

 VITE v3.2.1 ready in 568 ms
➜ Local: http://127.0.0.1:3000/
➜ Network: use --host to expose
window is not defined
ReferenceError: window is not defined
at /private/tmp/console/src/lib/stores/sdk.ts:16:61
at async instantiateModule (file:///private/tmp/console/node_modules/vite/dist/node/chunks/dep-d29b4e33.js:54234:9)
window is not defined
ReferenceError: window is not defined
at /private/tmp/console/src/lib/stores/sdk.ts:16:61
at async instantiateModule (file:///private/tmp/console/node_modules/vite/dist/node/chunks/dep-d29b4e33.js:54234:9)
window is not defined
ReferenceError: window is not defined
at /private/tmp/console/src/lib/stores/sdk.ts:16:61
at async instantiateModule (file:///private/tmp/console/node_modules/vite/dist/node/chunks/dep-d29b4e33.js:54234:9)

Add note about adblocker because this error occurs with adblocker enabled:

TypeError: Failed to fetch dynamically imported module: http://localhost:3000/.svelte-kit/generated/nodes/0.js

Test Plan

Manual

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

Add step for creating .env file and note for adblocker.
@vercel

vercelBot commented Dec 16, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
console✅ Ready (Inspect)Visit PreviewDec 16, 2022 at 5:19PM (UTC)

@stnguyen90stnguyen90 mentioned this pull request Dec 19, 2022
2 tasks
@stnguyen90
stnguyen90 removed the request for review from christyjacob4January 24, 2023 19:12
@TorstenDittmann
TorstenDittmann merged commit 4f14c2d into mainJan 27, 2023
@TorstenDittmann
TorstenDittmann deleted the feat-contributing-steps branch January 27, 2023 12:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stnguyen90@ArmanNik@TorstenDittmann