Skip to content

feat: set default type of datetime to null#235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TorstenDittmann merged 4 commits into from
Jan 27, 2023
Merged

feat: set default type of datetime to null #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e747adc
feat: set default type of datetime to null
christyjacob4 Jan 16, 2023
c37db3c
fix: set url fields to null when empty
christyjacob4 Jan 16, 2023
fc79543
fix: set url fields to null when empty
christyjacob4 Jan 16, 2023
8a11fb1
fix: method name
christyjacob4 Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/lib/elements/forms/inputURL.svelte
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,6 +38,12 @@
error = element.validationMessage;
};

const handleInput = () => {
if (value === '') {
value = null;
}
Comment on lines +42 to +44

@ArmanNikArmanNikJan 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is any difference, but is there a reason why we handle it like this instead of doing

$: if(!value){value=null}

@christyjacob4christyjacob4Jan 16, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmanNik I tried it, but on doing this, for some reason the update button stops working. It does not detect a change in the input field that way

Screen.Recording.2023-01-16.at.9.04.41.PM.mov

@ArmanNikArmanNikJan 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahaahahahah got it 💪 that's a very weird behavior 😆

};

$: if (value) {
error = null;
}
Expand All@@ -56,6 +62,7 @@
type="url"
autocomplete={autocomplete ? 'on' : 'off'}
bind:value
on:input={handleInput}
bind:this={element}
on:invalid={handleInvalid} />
</div>
Expand Down
4 changes: 2 additions & 2 deletions ...ect]/databases/database-[database]/collection-[collection]/document-[document]/+layout.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,15 +26,15 @@ export const load: LayoutLoad = async ({ params, parent, depends }) => {
if (array) {
document[key] = document[key].map((n: string) => {
if (!n) {
return '';
return null;
}
return new Date(n).toISOString().slice(0, 23);
});
} else {
if (document[key]) {
document[key] = new Date(document[key]).toISOString().slice(0, 23);
} else {
document[key] = '';
document[key] = null;
}
}
}
Expand Down
5 changes: 3 additions & 2 deletions ...atabases/database-[database]/collection-[collection]/document-[document]/attribute.svelte
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,10 +5,11 @@
import Enum from './attributes/enum.svelte';
import Integer from './attributes/integer.svelte';
import String from './attributes/string.svelte';
import Url from './attributes/url.svelte';

export let id: string;
export let label: string;
export let value: string | number | boolean;
export let value: string | number | boolean | null;
export let attribute:
| Models.AttributeBoolean
| Models.AttributeEmail
Expand All@@ -30,7 +31,7 @@

const attributesFormatMap = {
ip: String,
url: String,
url: Url,
email: String,
enum: Enum
};
Expand Down
11 changes: 11 additions & 0 deletions ...ses/database-[database]/collection-[collection]/document-[document]/attributes/url.svelte
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
<script lang="ts">
import InputURL from '$lib/elements/forms/inputURL.svelte';
import type { Models } from '@aw-labs/appwrite-console';

export let id: string;
export let label: string;
export let value: string | null;
export let attribute: Models.AttributeUrl;
</script>

<InputURL {id} {label} showLabel={!!label?.length} required={attribute.required} bind:value />