Skip to content

Arman educational - #3

Merged
TorstenDittmann merged 27 commits into
mainfrom
arman_educational
May 9, 2022
Merged

Arman educational#3
TorstenDittmann merged 27 commits into
mainfrom
arman_educational

Conversation

@ArmanNik

@ArmanNikArmanNik commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Most of the components are new so there shouldn't any problems.
I also modified existing inputs by adding some options.
The SwitchBox component is still a WIP.

ArmanNik added 20 commits April 8, 2022 16:15
@ArmanNik
Created Avatar component
4f138b4
@ArmanNik
Changed 'size' prop type from string to number in Avatar
212a799
@ArmanNik
inputSeach now updates on clear
e631891
@ArmanNik
better name for change function
b6248d7
@ArmanNik
fix valueChange not getting called & typescript
d1368dd
@ArmanNik
InputSearch unit testing
6e80088
@ArmanNik
Created switchBox + test, added it to users settings
6d28168
@ArmanNik
added option to disable autocomplete in inputText
bd4b068
@ArmanNik
added option to disable meter in inputText
8305c37
@ArmanNik
fixed small typo in footer
5d2b465
@ArmanNik
created switchBoxes component
692363f
@ArmanNik
modified switchBox tests
43e71ff
@ArmanNik
WIP created oauth modal, logic for auth methods user setting page
362b77a
@ArmanNik
updated todo format
61abb31
@ArmanNik
created authLimit component and logic
4398558
@ArmanNik
cleaned up code in setting page
2727ff7
@ArmanNik
created elementCount component and test
cbdba8a
@ArmanNik
added elementCount to various pages
2c5860c
@ArmanNik
created infoSection component added it to modals
e3381e1
@ArmanNik
Merge branch 'main' of github.com:appwrite/appwrite-console-poc into …
facc384
…arman_educational
@vercel

vercelBot commented Apr 22, 2022

Copy link
Copy Markdown

@ArmanNik is attempting to deploy a commit to the appwrite Team on Vercel.

To accomplish this, @ArmanNik needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

TorstenDittmann
TorstenDittmann requested changes Apr 23, 2022
View reviewed changes

@TorstenDittmannTorstenDittmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super happy with how the transitions turned out.

I think they need a few more iterations 👍🏻 Do you mind moving the transitions from here into its own PR?

Comment threadsrc/lib/components/avatar.svelte Outdated
Comment threadsrc/lib/components/elementCount.svelte Outdated
Comment threadsrc/lib/elements/forms/inputText.svelte Outdated
@ArmanNik

ArmanNik commented Apr 24, 2022

Copy link
Copy Markdown
ContributorAuthor

Yeah, I wasn't satisfied with the transitions either... I'll move them into a different PR and implement your suggestions first thing on Tuesday 👍

@ArmanNik

ArmanNik commented Apr 26, 2022

Copy link
Copy Markdown
ContributorAuthor

@TorstenDittmann let me know if I missed anything :)

TorstenDittmann
TorstenDittmann reviewed Apr 27, 2022
View reviewed changes

@TorstenDittmannTorstenDittmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing 🙂

Comment threadsrc/routes/console/[project]/users/_setUserLimit.svelte Outdated
@vercel

vercelBot commented Apr 27, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
svelte-console✅ Ready (Inspect)Visit PreviewApr 27, 2022 at 10:33AM (UTC)

@TorstenDittmann
TorstenDittmann merged commit b652798 into mainMay 9, 2022
@TorstenDittmann
TorstenDittmann deleted the arman_educational branch May 9, 2022 14:42
stnguyen90 pushed a commit that referenced this pull request Sep 28, 2023
@TorstenDittmann
Merge pull request#3from appwrite-labs/feat-heading-font
e6f6e67
Update heading font from Poppins to Aeonik Pro
@coderabbitaicoderabbitaiBot mentioned this pull request Oct 16, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmannTorstenDittmannTorstenDittmann requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ArmanNik@TorstenDittmann