Skip to content

Refactor: change create file from modal to wizard - #313

Merged
ArmanNik merged 14 commits into
billingfrom
refactor/create-file-wizard
Dec 12, 2023
Merged

Refactor: change create file from modal to wizard#313
ArmanNik merged 14 commits into
billingfrom
refactor/create-file-wizard

Conversation

@TGlide

@TGlideTGlide commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Changes Create File from modal to a wizard

Test Plan

Manual

Related PRs and Issues

N/a

Have you read the Contributing Guidelines on issues?

Yes

@TGlideTGlide added the enhancement New feature or request label Feb 20, 2023
@TGlideTGlide self-assigned this Feb 20, 2023
@vercel

vercelBot commented Feb 20, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
console✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 12, 2023 0:02am
console-1-3-preview✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 12, 2023 0:02am
console-cloud✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 12, 2023 0:02am
console-preview✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 12, 2023 0:02am
console-preview-cloud✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 12, 2023 0:02am

@eldadfux

eldadfux commented Mar 4, 2023•
edited by gewenyu99
Loading

Copy link
Copy Markdown
Member

@TGlide title should be Create file not Upload file. @gewenyu99 I think all the wizard steps should use labels / nouns to describe the steps instead of using verbs / actions. Does this align with our UX writing?
image

🤔 Yeah, we don't have to write full sentences for these things. Why write more when fewer words do trick insert Patrick star impression.

@gewenyu99

gewenyu99 commented Mar 9, 2023

Copy link
Copy Markdown

Sorry I edited Eldad's message by accident.

🤔 Yeah, we don't have to write full sentences for these things. Why write more when fewer words do trick insert Patrick star impression.

@TGlide

TGlide commented Mar 9, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Sorry I edited Eldad's message by accident.

🤔 Yeah, we don't have to write full sentences for these things. Why write more when fewer words do trick insert Patrick star impression.

@heyCarla@chenparnasa should we edit the overall copy here then?

@heyCarla

heyCarla commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

@heyCarla@chenparnasa should we edit the overall copy here then?

To be clear -- we should be using the copy, Create file for the following:

  • the wizard title in the nav bar
  • the first wizard step
  • the content/right side title for the first step

Is that correct, @eldadfux@gewenyu99?

ArmanNik
ArmanNik reviewed Mar 16, 2023
View reviewed changes
Comment threadsrc/lib/layout/wizardStep.svelte
Comment on lines +28 to +33
<style>
.hide-divider {
padding-block-end: 0;
border-block-end: none;
}
</style>

@ArmanNikArmanNikMar 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this in pink? @elad2412

Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/android/step2.svelte Outdated
Comment threadsrc/routes/console/project-[project]/storage/bucket-[bucket]/create-file/step1.svelte
@gewenyu99

gewenyu99 commented Mar 20, 2023

Copy link
Copy Markdown

@heyCarla@chenparnasa should we edit the overall copy here then?

To be clear -- we should be using the copy, Create file for the following:

  • the wizard title in the nav bar
  • the first wizard step
  • the content/right side title for the first step

Is that correct, @eldadfux@gewenyu99?

Yep :)

@TGlide
TGlide requested a review from ArmanNikApril 17, 2023 11:06
@TGlide

TGlide commented Apr 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Changed copy to create file

@stnguyen90
stnguyen90 marked this pull request as draft October 5, 2023 17:31
@stnguyen90

stnguyen90 commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Converting to draft due to merge conflicts.

@gewenyu99

gewenyu99 commented Oct 6, 2023•
edited
Loading

Copy link
Copy Markdown

Holy gosh
this is old.

@ArmanNik
ArmanNik changed the base branch from main to billingDecember 12, 2023 11:56
@ArmanNik
ArmanNik marked this pull request as ready for review December 12, 2023 11:59
@ArmanNik
ArmanNik merged commit 9ec2f21 into billingDec 12, 2023
@ArmanNik
ArmanNik deleted the refactor/create-file-wizard branch December 12, 2023 12:00
@github-actionsgithub-actionsBot mentioned this pull request Jan 1, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmannTorstenDittmannAwaiting requested review from TorstenDittmann
2 more reviewers
@heyCarlaheyCarlaheyCarla left review comments
@ArmanNikArmanNikArmanNik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TGlideTGlide

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@TGlide@eldadfux@gewenyu99@heyCarla@stnguyen90@ArmanNik@TorstenDittmann