Skip to content

Fix: Added Rebuild button for function view when build fails during deployment - #376

Merged
TorstenDittmann merged 6 commits into
appwrite:mainfrom
singhbhaskar:feat-4840-allow-retrying-failed-builds
Jun 1, 2023
Merged

Fix: Added Rebuild button for function view when build fails during deployment#376
TorstenDittmann merged 6 commits into
appwrite:mainfrom
singhbhaskar:feat-4840-allow-retrying-failed-builds

Conversation

@singhbhaskar

@singhbhaskarsinghbhaskar commented Apr 1, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a new button to rebuild function deployment if it fails. The button is not showed when the build is successfull.

Test Plan

Mannual testing. Ran npm run build, npm run format and npm run lint. Attaching the screenshot for the following test.

Screenshot for function failure:

rebuildButtonFromOptionMenu

Screenshot for Model Alert when user clicks on rebuild button:

ModelAlertToConfirmRebuild

Screenshot for Notification alert when rebuild request is process by the SDK:

NotificationAfterRebuildRequestSuccessfullyHitsTheBackend

Screenshot for Successful function build which doesn't show the rebuild option.

rebuildButtonNotShowingForSuccessfulFunctionDeployment

Related PRs and Issues

appwrite/appwrite#4840

Have you read the Contributing Guidelines on issues?

Yes I have read the contributing guidelines.

@vercel

vercelBot commented Apr 1, 2023

Copy link
Copy Markdown

@singhbhaskar is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@stnguyen90
stnguyen90 requested review from TorstenDittmann and stnguyen90 and removed request for TorstenDittmannApril 6, 2023 16:23

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Good idea on the confirmation modal too! I just have some minor text suggestions.

@singhbhaskar

Copy link
Copy Markdown
ContributorAuthor

This looks great! Good idea on the confirmation modal too! I just have some minor text suggestions.

Sure Steven, I'll update the suggest changes. Thanks

@singhbhaskar
singhbhaskarforce-pushed the feat-4840-allow-retrying-failed-builds branch from 75cca9d to 2120d77CompareApril 16, 2023 10:47
@singhbhaskar

Copy link
Copy Markdown
ContributorAuthor

Hi @stnguyen90 ,
I have addressed all the comments. Kindly review again. Attaching the latest screenshots.

Screenshot for function failure:

retryBuildOptions

Screenshot for Model Alert when user clicks on rebuild button:

retryBuildModel

Screenshot for Notification alert when rebuild request is process by the SDK:

retryBuildSucess

@stnguyen90

Copy link
Copy Markdown
Contributor

@singhbhaskar looks like the tests are failing. Perhaps the package name has changed?

Also, please make sure to re-request a review when you're ready for a review.

@aw-labs/appwrite-console to
@appwrite.io/console for rebuild.svelte
@singhbhaskar

Copy link
Copy Markdown
ContributorAuthor

Hi @stnguyen90 ,
Updated the code to fix test. Please review.

@singhbhaskar

Copy link
Copy Markdown
ContributorAuthor

I am able to successfully run lint and test in my local system but for some reason it's failing during the check. Can you trigger a rebuild?

@stnguyen90

Copy link
Copy Markdown
Contributor

I am able to successfully run lint and test in my local system but for some reason it's failing during the check. Can you trigger a rebuild?

@TorstenDittmann, I also tried to check the linting and it seems fine.

I manually ran the tests and they all passed:

image

I can confirm the modal triggers a new build:

image

What do you think about just merging?

@TorstenDittmannTorstenDittmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once you have fixed the formatting issues we can merge 👍🏻

just run npm run format

@singhbhaskar

Copy link
Copy Markdown
ContributorAuthor

npm run format

Hi,
I had already ran npm run format when raising the PR. I re-ran it just now and there is no file format change for any file. Can you tell which file is having format issue?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@singhbhaskar@stnguyen90@TorstenDittmann