Uh oh!
There was an error while loading. Please reload this page.
Fix: Added Rebuild button for function view when build fails during deployment - #376
Conversation
@singhbhaskar is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
stnguyen90
left a comment
There was a problem hiding this comment.
This looks great! Good idea on the confirmation modal too! I just have some minor text suggestions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
singhbhaskar
commented
Apr 10, 2023
Sure Steven, I'll update the suggest changes. Thanks |
Uh oh!
There was an error while loading. Please reload this page.
build fails during deployment.
75cca9d to
2120d77Comparesinghbhaskar
commented
Apr 16, 2023
Hi @stnguyen90 , Screenshot for function failure:Screenshot for Model Alert when user clicks on rebuild button:Screenshot for Notification alert when rebuild request is process by the SDK: |
stnguyen90
commented
Apr 19, 2023
@singhbhaskar looks like the tests are failing. Perhaps the package name has changed? Also, please make sure to re-request a review when you're ready for a review. |
@aw-labs/appwrite-console to @appwrite.io/console for rebuild.svelte
singhbhaskar
commented
Apr 21, 2023
Hi @stnguyen90 , |
Uh oh!
There was an error while loading. Please reload this page.
singhbhaskar
commented
Apr 26, 2023
I am able to successfully run lint and test in my local system but for some reason it's failing during the check. Can you trigger a rebuild? |
stnguyen90
commented
May 3, 2023
@TorstenDittmann, I also tried to check the linting and it seems fine. I manually ran the tests and they all passed: I can confirm the modal triggers a new build: What do you think about just merging? |
TorstenDittmann
left a comment
There was a problem hiding this comment.
once you have fixed the formatting issues we can merge 👍🏻
just run npm run format
singhbhaskar
commented
May 9, 2023
Hi, |
…ow-retrying-failed-builds





What does this PR do?
Adds a new button to rebuild function deployment if it fails. The button is not showed when the build is successfull.
Test Plan
Mannual testing. Ran
npm run build,npm run formatandnpm run lint. Attaching the screenshot for the following test.Screenshot for function failure:
Screenshot for Model Alert when user clicks on rebuild button:
Screenshot for Notification alert when rebuild request is process by the SDK:
Screenshot for Successful function build which doesn't show the rebuild option.
Related PRs and Issues
appwrite/appwrite#4840
Have you read the Contributing Guidelines on issues?
Yes I have read the contributing guidelines.