Skip to content

refactor: onboarding style changes - #380

Merged
christyjacob4 merged 11 commits into
mainfrom
fix/onboarding-styles
Aug 8, 2023
Merged

refactor: onboarding style changes#380
christyjacob4 merged 11 commits into
mainfrom
fix/onboarding-styles

Conversation

@TGlide

@TGlideTGlide commented Apr 4, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Changes some styles in the onboarding to better fit design schemas
  • Changes copy in onboarding and Add Platform wizards

Test Plan

Manual

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes

@TGlideTGlide self-assigned this Apr 4, 2023
@vercel

vercelBot commented Apr 4, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
console✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 8, 2023 5:06pm
console-1-3-preview✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 8, 2023 5:06pm
console-cloud✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 8, 2023 5:06pm
console-next✅ Ready (Inspect)Visit Preview💬 Add feedbackAug 8, 2023 5:06pm

@TGlide
TGlide marked this pull request as draft April 5, 2023 09:20
@TGlide
TGlide requested a review from gewenyu99April 11, 2023 18:12
@TGlideTGlide added the enhancement New feature or request label Apr 11, 2023
@gewenyu99

gewenyu99 commented Apr 11, 2023

Copy link
Copy Markdown

@TGlide Can you tag me on what I need to review?

Also, let's make sure we hit all the copywriting changes for the onboarding changes. I'll setup a quick sync with you about this.

@TGlide
TGlide changed the base branch from main to billingApril 13, 2023 14:03
@TGlide
TGlide changed the base branch from billing to mainApril 13, 2023 14:03
@TGlide
TGlide marked this pull request as ready for review April 17, 2023 09:57
@TGlide

TGlide commented Apr 17, 2023

Copy link
Copy Markdown
ContributorAuthor

@gewenyu99 all of the files are mostly copy review regarding new copy on Onboarding and Add Platform pages. But you can also go through the preview link on Vercel to check it out if you prefer!

gewenyu99
gewenyu99 suggested changes Apr 18, 2023
View reviewed changes

@gewenyu99gewenyu99 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see it through :DDD

Comment threadsrc/routes/console/project-[project]/overview/platforms/createApple.svelte
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/android/step2.svelte
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/flutter/step1.svelte
@christyjacob4
christyjacob4 changed the base branch from main to 1.4.xAugust 8, 2023 15:24
@christyjacob4
christyjacob4 changed the base branch from 1.4.x to mainAugust 8, 2023 15:42
gewenyu99
gewenyu99 suggested changes Aug 8, 2023
View reviewed changes
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/web/step3.svelte Outdated
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/flutter/step3.svelte
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/flutter/step3.svelte Outdated
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/apple/step3.svelte Outdated
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/flutter/step3.svelte
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/web/step3.svelte Outdated
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/android/step3.svelte Outdated
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/android/step3.svelte Outdated
Comment threadsrc/routes/console/project-[project]/overview/platforms/wizard/apple/step3.svelte Outdated
gewenyu99
gewenyu99 approved these changes Aug 8, 2023
View reviewed changes

@gewenyu99gewenyu99 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check to make sure you're not missing periods and merge XD

@christyjacob4
christyjacob4 merged commit be7f306 into mainAug 8, 2023
@github-actionsgithub-actionsBot mentioned this pull request Sep 1, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christyjacob4christyjacob4christyjacob4 left review comments
+2 more reviewers
@gewenyu99gewenyu99gewenyu99 approved these changes
@ArmanNikArmanNikArmanNik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TGlideTGlide

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TGlide@gewenyu99@christyjacob4@ArmanNik