Skip to content

Tests branch merge - #4

Merged
TorstenDittmann merged 14 commits into
mainfrom
tests
May 13, 2022
Merged

Tests branch merge#4
TorstenDittmann merged 14 commits into
mainfrom
tests

Conversation

@ArmanNik

@ArmanNikArmanNik commented May 9, 2022

Copy link
Copy Markdown
Contributor

@TorstenDittmann let me know if the implementation for the copy component fallback is correct. The same goes for component tests.

As for the rest:

  • The radio input needs a group test. Should I create a mock component and create a separate test or there is a better way?
  • The test for "state changes" to the select input component might be a little brittle maybe 🙃

@vercel

vercelBot commented May 9, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
svelte-console✅ Ready (Inspect)Visit PreviewMay 13, 2022 at 4:27PM (UTC)

TorstenDittmann
TorstenDittmann requested changes May 9, 2022
View reviewed changes
Comment threadsrc/lib/components/copy.svelte Outdated
Comment threadsrc/lib/components/copy.svelte Outdated
Comment threadsrc/lib/components/copy.svelte Outdated
@ArmanNik

ArmanNik commented May 13, 2022

Copy link
Copy Markdown
ContributorAuthor

@TorstenDittmann let me know if anything is missing :)

@TorstenDittmann
TorstenDittmann merged commit 4997d2c into mainMay 13, 2022
@TorstenDittmann
TorstenDittmann deleted the tests branch May 13, 2022 16:44
stnguyen90 added a commit that referenced this pull request Sep 28, 2023
@stnguyen90
Merge pull request#4from appwrite-labs/feat-login-sign-up-pages
413209b
Update login and sign up pages
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmannTorstenDittmannTorstenDittmann requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ArmanNik@TorstenDittmann