Skip to content

feat: accessible tab kbd navigation - #437

Merged
TorstenDittmann merged 4 commits into
mainfrom
feat/accessible-tabs
Jul 11, 2023
Merged

feat: accessible tab kbd navigation#437
TorstenDittmann merged 4 commits into
mainfrom
feat/accessible-tabs

Conversation

@TGlide

@TGlideTGlide commented May 10, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds accessible tab controls, following the ARIA APG: https://www.w3.org/WAI/ARIA/apg/

Test Plan

Manual

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes

@TGlideTGlide added the enhancement New feature or request label May 10, 2023
@TGlideTGlide self-assigned this May 10, 2023
@vercel

vercelBot commented May 10, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
console✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 3, 2023 11:42am
console-cloud✅ Ready (Inspect)Visit Preview💬 Add feedbackJul 3, 2023 11:42am

ArmanNik
ArmanNik reviewed May 30, 2023
View reviewed changes

@ArmanNikArmanNik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future improvement suggestion:

When a tab is selected, and navigation is triggered, the tabs lose focus after the page loads.
It would be nice to keep the focus on the tab after navigation 🤔

Comment threadsrc/lib/components/tab.svelte Outdated
Comment threadsrc/lib/components/tab.svelte Outdated
ArmanNik
ArmanNik reviewed May 30, 2023
View reviewed changes

@ArmanNikArmanNik left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future improvement suggestion (might not be easily doable):

When a tab is selected, and navigation is triggered, the tabs lose focus after the page loads.
It would be nice to keep the focus on the tab after navigation 🤔

TorstenDittmann
TorstenDittmann reviewed May 31, 2023
View reviewed changes

@TorstenDittmannTorstenDittmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once @ArmanNik comments has been resolved we can merge it :)

@TGlide

TGlide commented May 31, 2023

Copy link
Copy Markdown
ContributorAuthor

Future improvement suggestion (might not be easily doable):

When a tab is selected, and navigation is triggered, the tabs lose focus after the page loads. It would be nice to keep the focus on the tab after navigation 🤔

Nice idea!

@TGlide

TGlide commented May 31, 2023

Copy link
Copy Markdown
ContributorAuthor

@TorstenDittmann@ArmanNik done 😉

@TorstenDittmann

TorstenDittmann commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

@TorstenDittmann@ArmanNik done 😉

tests are failing 👍🏻

@TGlide

TGlide commented Jul 3, 2023

Copy link
Copy Markdown
ContributorAuthor

@TorstenDittmann@ArmanNik done 😉

tests are failing 👍🏻

Fixed!

@TorstenDittmann
TorstenDittmann merged commit 33432d2 into mainJul 11, 2023
@TorstenDittmann
TorstenDittmann deleted the feat/accessible-tabs branch July 11, 2023 14:39
@github-actionsgithub-actionsBot mentioned this pull request Aug 1, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmannTorstenDittmannTorstenDittmann approved these changes
@ArmanNikArmanNikAwaiting requested review from ArmanNik

Assignees

@TGlideTGlide

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TGlide@TorstenDittmann@ArmanNik