Uh oh!
There was an error while loading. Please reload this page.
Clarify Deleting Account - #447
Closed
stnguyen90 wants to merge 1 commit into
Closed
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArmanNik
suggested changes
May 19, 2023
ArmanNik
left a comment
Contributor
There was a problem hiding this comment.
@stnguyen90 let's also clear all the locally stored data (both local and session storage), otherwise the user won't be able to login with another account
I would also suggest adding a checkbox for confirmation the same way we do it for documents with relationships 😄
stnguyen90force-pushed
the
feat-clarify-delete-account
branch
from
May 19, 2023 14:51
7c6a8c5 to
9f94f46Comparestnguyen90
commented
May 19, 2023
ContributorAuthor
ArmanNik
commented
May 21, 2023
Contributor
There are still issues with the checkbox style on Cloud... the solution is to update Cloud to the latest version of Appwrite 🙃 |
ArmanNik
approved these changes
May 21, 2023
stnguyen90force-pushed
the
feat-clarify-delete-account
branch
from
May 23, 2023 16:28
9f94f46 to
fc0f2e3Comparestnguyen90force-pushed
the
feat-clarify-delete-account
branch
from
May 23, 2023 16:30
fc0f2e3 to
878f29dComparestnguyen90
marked this pull request as draft
May 23, 2023 17:31
Console accounts are not actually deleted so a user won't be able to re-create their account after "deleting" it.
stnguyen90force-pushed
the
feat-clarify-delete-account
branch
from
May 24, 2023 18:37
878f29d to
11d61d1Comparestnguyen90
marked this pull request as ready for review
July 28, 2023 20:32
eldadfux
commented
Aug 1, 2023
Member
Not sure about this feature, let's wait. It might be better to just allow deletion and trust backups for any abusive play. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Console accounts are not deleted, so a user won't be able to re-create their account after "deleting" it.
Test Plan
Manual:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes