Uh oh!
There was an error while loading. Please reload this page.
Update the OAuth2 success and failure pages - #452
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stnguyen90force-pushed
the
feat-3930-missing-redirect-url
branch
from
May 23, 2023 17:43
6ee7593 to
d03a7fcComparestnguyen90force-pushed
the
feat-3930-missing-redirect-url
branch
from
May 24, 2023 18:33
d03a7fc to
63dfb73Comparestnguyen90force-pushed
the
feat-3930-missing-redirect-url
branch
from
May 24, 2023 18:49
63dfb73 to
f257d24Comparestnguyen90
marked this pull request as ready for review
May 28, 2023 15:05
stnguyen90
commented
May 28, 2023
ContributorAuthor
FYI, design has reviewed and approved how this looks. |
stnguyen90
commented
May 29, 2023
ContributorAuthor
Converting to draft because the design team has asked us to put a link on the page when redirecting. |
stnguyen90
marked this pull request as draft
May 29, 2023 15:11
stnguyen90force-pushed
the
feat-3930-missing-redirect-url
branch
from
May 30, 2023 20:23
f257d24 to
58b1230Comparestnguyen90force-pushed
the
feat-3930-missing-redirect-url
branch
from
June 5, 2023 23:22
58b1230 to
69d054dComparestnguyen90force-pushed
the
feat-3930-missing-redirect-url
branch
from
June 6, 2023 19:40
69d054d to
803a032Comparestnguyen90force-pushed
the
feat-3930-missing-redirect-url
branch
from
June 9, 2023 20:04
803a032 to
6b5407bComparestnguyen90
marked this pull request as ready for review
June 9, 2023 20:05
1. Update design to be more consistent with other pages, while still unbranded 2. Update sizing to be more mobile friendly as the original heading size was truncated on mobile 3. Show a different message when redirecting back to the app to clarify the login was successful 4. Close the window after redirecting so the user doesn't have to
stnguyen90force-pushed
the
feat-3930-missing-redirect-url
branch
from
June 23, 2023 00:59
6b5407b to
10afbd9Comparestnguyen90
commented
Jul 10, 2023
ContributorAuthor
@TorstenDittmann, how does this look? |
eldadfux
approved these changes
Jul 19, 2023
Yeeeeessssss 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closesappwrite/appwrite#3930
Test Plan
Manual
Light Mobile Redirect
Light Desktop Missing Redirect URL
Dark Mobile Redirect
Dark Desktop Missing Redirect URL
Videos of the Redirect
Success
success.webm
Failure
failure.mov
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes