Uh oh!
There was an error while loading. Please reload this page.
Add user labels to user list and detail pages - #457
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stnguyen90
commented
Jun 2, 2023
@chenparnasa, here's what I have so far for the user labels. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
heyCarla
left a comment
There was a problem hiding this comment.
I think @chenparnasa left you some comments about this in Figma re: replacing the original helper text with the warning message if an invalid tag is added to the input field. Otherwise I like the idea of calling out the specific label in the warning!
chenparnasa
commented
Jun 6, 2023
@stnguyen90 I left comments in Figma on how we should handle the helper texts :) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
a8d6f7b to
82d6a80Comparestnguyen90
commented
Jul 20, 2023
@TorstenDittmann, would you please review this when you get a chance? |
82d6a80 to
126c6eaCompare126c6ea to
d6d960fCompare
What does this PR do?
Add user labels to user list and detail pages
Test Plan
Manual:
Users List
User Detail
without error
with error
Related PRs and Issues
Depends on:
Have you read the Contributing Guidelines on issues?
Yes