Uh oh!
There was an error while loading. Please reload this page.
Appwrite console internationalization : Typesafe-i18n - #459
Appwrite console internationalization : Typesafe-i18n #459goswamianshuman wants to merge 46 commits into
Conversation
@goswamianshuman is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
goswamianshuman
commented
Jun 4, 2023
@TorstenDittmann, @TGlide, @ArmanNik tagging you guys here for a review of typesafe-i18n library for the internationalization on the recommendations of @TorstenDittmann.🙂 |
TGlide
commented
Jun 6, 2023
Hi @goswamianshuman ! Thanks for the PR. I'm confused though, why are there 2 separate PRs? Does this PR contain code from #451? Or is this PR supposed to be merged only after #451? |
goswamianshuman
commented
Jun 6, 2023
Hey @TGlide actully the following PR is performed with typesafe-i18n library Torsten told me that please create a seperate library for typesafe-i18n , #451 is performed by using i18next library. the method for performing both the libraries are different that is why Torsten recommended to create a new PR. |
TorstenDittmann
left a comment
There was a problem hiding this comment.
Would it be possible if you only include code for typesafe-i18n in this PR so its going to be easier for review? 👍🏻
goswamianshuman
commented
Jun 6, 2023
there is only typesafe-i18n code here as per your recommendation I removed everything just kept typesafe-i18n |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
goswamianshuman
commented
Jun 9, 2023
hey, @TGlide have a look here, https://github.com/ivanhofer/typesafe-i18n-demo-svelte/tree/master I think this might resolve many doubts regarding this PR. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What does this PR do?
Test Plan
Related PRs and Issues