Uh oh!
There was an error while loading. Please reload this page.
fix: qa last fixes - #522
Merged
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArmanNik
marked this pull request as draft
August 29, 2023 10:22
Comment on lines
+60
to
+66
| for (const [key, value] of Object.entries($templateConfig.variables)) { | ||
| await sdk.forProject.functions.createVariable( | ||
| response.$id, | ||
| key, | ||
| value?.toString() | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
can we use a Promise.all helper for better performance?
TorstenDittmann
approved these changes
Aug 29, 2023
This was referenced Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix variable creation during function creation.
Feat dynamic component for variables