Uh oh!
There was an error while loading. Please reload this page.
Update create function cover for case where VCS is not enabled - #544
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ArmanNik
suggested changes
Sep 13, 2023
ArmanNik
left a comment
Contributor
There was a problem hiding this comment.
I don't think it makes sense to await the consoleVariables in the main layout.ts we can await them when we need them 👍
| isDomainsEnabled = (await $consoleVariables)?._APP_DOMAIN_ENABLED === true; | ||
| }); | ||
| const isDomainsEnabled = $consoleVariables?._APP_DOMAIN_ENABLED === true; |
Contributor
There was a problem hiding this comment.
$consoleVariables might need to be awaited since we are not doing it in the layout
| onMount(async () => { | ||
| isAssistantEnabled = (await $consoleVariables)?._APP_ASSISTANT_ENABLED === true; | ||
| }); | ||
| const isAssistantEnabled = $consoleVariables?._APP_ASSISTANT_ENABLED === true; |
Contributor
There was a problem hiding this comment.
This might need to be awaited too 🤔
| return { | ||
| consoleVariables: sdk.forConsole.console.variables(), | ||
| consoleVariables: await sdk.forConsole.console.variables(), |
Contributor
There was a problem hiding this comment.
We didn't await it here to avoid a needless extra fetch request that might slow stuff down 😄
ContributorAuthor
There was a problem hiding this comment.
I'm not sure if it's worth it because:
- it complicates the rest of the code
- the variables are fetched 20ms after version even before this change
What could be useful is fetching both the version and the variables concurrently.
| import { consoleVariables } from '$routes/console/store'; | ||
| const functionId = $page.params.function; | ||
| const isVcsEnabled = $consoleVariables?._APP_VCS_ENABLED === true; |
stnguyen90force-pushed
the
feat-6180-github-not-configured
branch
from
September 13, 2023 18:26
17ac61d to
93a7323Compareawait the data during load so it's available downstream without needing to await.
stnguyen90force-pushed
the
feat-6180-github-not-configured
branch
from
September 13, 2023 18:53
93a7323 to
d6def22CompareUh oh!
There was an error while loading. Please reload this page.
stnguyen90force-pushed
the
feat-6180-github-not-configured
branch
from
September 13, 2023 22:37
d6def22 to
a3bc3f8CompareArmanNik
approved these changes
Sep 14, 2023
This was referenced Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closesappwrite/appwrite#6180
Test Plan
Manual w/o VCS:
Manual w/ VCS:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes