Skip to content

Updated Client Side Cron Regex - #553

Merged
TorstenDittmann merged 7 commits into
appwrite:mainfrom
KanniShashankh:bug-5719-client-cron-regex-update
Oct 18, 2023
Merged

Updated Client Side Cron Regex#553
TorstenDittmann merged 7 commits into
appwrite:mainfrom
KanniShashankh:bug-5719-client-cron-regex-update

Conversation

@KanniShashankh

@KanniShashankhKanniShashankh commented Sep 14, 2023•
edited by stnguyen90
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Updated the Regex Pattern to correctly validate the cron syntax.
Mentioned the allowed values in a comment.

Test Plan

I tried a few statements and they validated correctly.

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@vercel

vercelBot commented Sep 14, 2023

Copy link
Copy Markdown

@KanniShashankh is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

navneetbz
navneetbz approved these changes Sep 15, 2023
View reviewed changes

@navneetbznavneetbz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stnguyen90
stnguyen90 self-requested a review September 15, 2023 20:27
@stnguyen90stnguyen90 linked an issue Sep 15, 2023 that may be closed by this pull request
🐛 Bug Report: Schedule function with minutes does not work appwrite/appwrite#5719
Closed
2 tasks
@vercel

vercelBot commented Sep 21, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
console✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 11, 2023 4:33pm
console-cloud✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 11, 2023 4:33pm
console-preview✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 11, 2023 4:33pm
console-preview-cloud✅ Ready (Inspect)Visit Preview💬 Add feedbackOct 11, 2023 4:33pm

stnguyen90
stnguyen90 previously requested changes Sep 21, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Please make sure the linter and tests pass.

@KanniShashankh

KanniShashankh commented Sep 22, 2023

Copy link
Copy Markdown
ContributorAuthor

Great work! Please make sure the linter and tests pass.

Done with the linter test, Investigating the problem in Unit testing which incorrectly validates the tests. Will push a commit soon

@github-actionsgithub-actionsBot mentioned this pull request Oct 1, 2023
Closed
@stnguyen90

stnguyen90 commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

@KanniShashankh there still seems to be a problem with the linter 🧐

@KanniShashankh
KanniShashankhforce-pushed the bug-5719-client-cron-regex-update branch from 5f7eda3 to c3faa36CompareOctober 11, 2023 13:05
@KanniShashankh

KanniShashankh commented Oct 11, 2023

Copy link
Copy Markdown
ContributorAuthor

@stnguyen90 To keep the regex simple, since this is just a frontend check, i have very much simplified the expression to match 5 segments of cron. Please let me know if i need to add something :)

@TorstenDittmann
TorstenDittmann merged commit 07da7e2 into appwrite:mainOct 18, 2023
@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmannTorstenDittmannTorstenDittmann approved these changes
@stnguyen90stnguyen90Awaiting requested review from stnguyen90
+1 more reviewer
@navneetbznavneetbznavneetbz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Schedule function with minutes does not work

4 participants

@KanniShashankh@stnguyen90@TorstenDittmann@navneetbz