Uh oh!
There was an error while loading. Please reload this page.
Add messaging providers route - #602
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4de6350 to
383a71fCompare| { id: 'status', title: 'Status', show: true } | ||
| ]); | ||
| export const providers = { |
There was a problem hiding this comment.
@TorstenDittmann, what do you think about having this JSON for the wizard for all providers. I wanted to try and minimize the number of places you'd need to go if we add a messaging provider in the future.
There was a problem hiding this comment.
Torsten: for now, let's continue with this.
Uh oh!
There was an error while loading. Please reload this page.
| try { | ||
| let response = { $id: '', name: '' }; | ||
| const providerId = $providerParams[$provider].providerId || ID.unique(); | ||
| switch ($provider) { |
There was a problem hiding this comment.
@TorstenDittmann, this is going to be long and annoying because there's a different method for each provider. Any thoughts on how to improve this?
There was a problem hiding this comment.
Torsten: for now, let's go with this.
| export const providerParams = writable<{ mailgun: Partial<MailgunProviderParams> }>({ | ||
| mailgun: null | ||
| }); |
There was a problem hiding this comment.
@TorstenDittmann, I wanted to do this to make the create/update part easier, but do you think it's not worth it and I should just have a writable for each provider?
There was a problem hiding this comment.
Torsten: for now, let's go with this.
383a71f to
8a954c6Compare8a954c6 to
517c609Comparefe1ab68 to
e84bea0Compare190cb67 to
4f8e32bCompare99d1eb1 to
5ec3593Compare180624d to
525401cCompared4d6578 to
c8e1786Compare525401c to
f46f432CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
What does this PR do?
Add messaging providers route
Test Plan
TBD
Related PRs and Issues
Parent:
Children:
Have you read the Contributing Guidelines on issues?
Yes