Skip to content

Fix file extension validation - #705

Merged
TorstenDittmann merged 8 commits into
appwrite:mainfrom
sourabpramanik:bug-7362-file-extension-validation
Apr 15, 2024
Merged

Fix file extension validation#705
TorstenDittmann merged 8 commits into
appwrite:mainfrom
sourabpramanik:bug-7362-file-extension-validation

Conversation

@sourabpramanik

@sourabpramaniksourabpramanik commented Jan 3, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR fixes the file input upload extension validation in create function. First found in the create function step 2.
fix

Test Plan

Manual test

Related PRs and Issues

Fixes#7362

Have you read the Contributing Guidelines on issues?

YES

@vercel

vercelBot commented Jan 3, 2024

Copy link
Copy Markdown

@sourabpramanik is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@sourabpramaniksourabpramanik changed the title Bug 7362 file extension validationFix: #7362 file extension validationJan 3, 2024
@stnguyen90
stnguyen90 self-requested a review January 4, 2024 01:30
@vercel

vercelBot commented Jan 5, 2024•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
console-cloud✅ Ready (Inspect)Visit Preview💬 Add feedbackApr 10, 2024 9:12pm
console-preview✅ Ready (Inspect)Visit Preview💬 Add feedbackApr 10, 2024 9:12pm
console-preview-cloud✅ Ready (Inspect)Visit Preview💬 Add feedbackApr 10, 2024 9:12pm

stnguyen90
stnguyen90 suggested changes Jan 5, 2024
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I tested this but was able to add an invalid file by dragging and dropping:

image

@sourabpramanik

sourabpramanik commented Jan 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Interesting. I will look into this again and make required changes. Thanks for pointing that out ✌️

@sourabpramaniksourabpramanik changed the title Fix: #7362 file extension validationFix: #7362 file extension validation in create functionJan 9, 2024
@sourabpramanik

sourabpramanik commented Jan 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Hey @stnguyen90 , I see you are checking the storage file upload but this issue was not found in storage. It was found in create manual Function step 2. You can check the gif I added to the PR.

stnguyen90
stnguyen90 reviewed Jan 29, 2024
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourabpramanik here's the same in the create manual function wizard:

image

@sourabpramanik

sourabpramanik commented Jan 29, 2024

Copy link
Copy Markdown
ContributorAuthor

Hmm gotta check that again I was unable to reproduce this last time. Thanks for pointing that out.

@github-actionsgithub-actionsBot mentioned this pull request Feb 1, 2024
Closed
@stnguyen90

stnguyen90 commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

@sourabpramanik, any update on this?

@sourabpramanik

sourabpramanik commented Mar 11, 2024

Copy link
Copy Markdown
ContributorAuthor

@sourabpramanik, any update on this?

Yes done

stnguyen90
stnguyen90 suggested changes Apr 8, 2024
View reviewed changes
Comment threadsrc/lib/elements/forms/inputFile.svelte Outdated
Comment threadsrc/lib/elements/forms/inputFile.svelte
@TorstenDittmann
TorstenDittmann merged commit 7ab1c4d into appwrite:mainApr 15, 2024
@stnguyen90stnguyen90 changed the title Fix: #7362 file extension validation in create functionFix file extension validation in create functionApr 24, 2024
@stnguyen90stnguyen90 changed the title Fix file extension validation in create functionFix file extension validationApr 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmannTorstenDittmannAwaiting requested review from TorstenDittmann
1 more reviewer
@stnguyen90stnguyen90stnguyen90 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Able to move to next screen after selecting wrong file extension for Function

3 participants

@sourabpramanik@stnguyen90@TorstenDittmann