Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Update production guide - #279

Merged
eldadfux merged 10 commits into
mainfrom
production-style-update
Jul 26, 2023
Merged

Update production guide#279
eldadfux merged 10 commits into
mainfrom
production-style-update

Conversation

@gewenyu99

@gewenyu99gewenyu99 commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

gewenyu99
gewenyu99 commented Oct 5, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
gewenyu99
gewenyu99 commented Oct 5, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml
gewenyu99
gewenyu99 commented Oct 5, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
gewenyu99
gewenyu99 commented Oct 5, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml
stnguyen90
stnguyen90 reviewed Oct 5, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
Comment threadapp/views/docs/production.phtml
Comment threadapp/views/docs/production.phtml Outdated
Comment threadapp/views/docs/production.phtml Outdated
Meldiron
Meldiron reviewed Oct 6, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
Meldiron
Meldiron reviewed Oct 6, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
Meldiron
Meldiron reviewed Oct 6, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
Meldiron
Meldiron reviewed Oct 6, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml
Meldiron
Meldiron reviewed Oct 6, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
Meldiron
Meldiron reviewed Oct 6, 2022
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
Meldiron
Meldiron previously requested changes Oct 6, 2022
View reviewed changes

@MeldironMeldiron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my review.

@gewenyu99@Meldiron
Update app/views/docs/production.phtml
4765233
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
@gewenyu99

gewenyu99 commented Oct 6, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks for the comments @Meldiron and @stnguyen90

I think the installation docs really does need a good touchup, esp. cause we want to keep our self-hosted service well supported :)

@stnguyen90stnguyen90 mentioned this pull request Oct 14, 2022
Closed
@gewenyu99
gewenyu99 marked this pull request as ready for review November 11, 2022 21:37
@gewenyu99

gewenyu99 commented Jun 7, 2023

Copy link
Copy Markdown
ContributorAuthor

gewenyu99-legendary-fishstick-77j4rw47w7gf94x-2080 preview app github dev_docs_production

@gewenyu99gewenyu99 changed the title Update production guide to conform to guidelines proposed in PR #229Update production guideJun 15, 2023
eldadfux
eldadfux reviewed Jul 8, 2023
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
Comment threadapp/views/docs/production.phtml Outdated
Comment threadapp/views/docs/production.phtml
Comment threadapp/views/docs/production.phtml Outdated
@gewenyu99

gewenyu99 commented Jul 10, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

localhost_2080_docs_production (1)

@gewenyu99
gewenyu99 requested a review from eldadfuxJuly 10, 2023 19:11
eldadfux
eldadfux reviewed Jul 25, 2023
View reviewed changes
Comment threadapp/views/docs/production.phtml Outdated
gewenyu99
gewenyu99 commented Jul 25, 2023
View reviewed changes
Comment threadapp/views/docs/production.phtml
@eldadfux
eldadfux dismissed Meldiron’s stale reviewJuly 26, 2023 00:01

Addressed comments.

@eldadfux
eldadfux merged commit 5258dae into mainJul 26, 2023
@github-actionsgithub-actionsBot mentioned this pull request Aug 1, 2023
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MeldironMeldironAwaiting requested review from Meldiron
2 more reviewers
@eldadfuxeldadfuxeldadfux approved these changes
@stnguyen90stnguyen90stnguyen90 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gewenyu99@eldadfux@stnguyen90@Meldiron