Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Offline docs intro - #330

Merged
gewenyu99 merged 12 commits into
feat-offline-supportfrom
feat-offline-support-intro
Feb 10, 2023
Merged

Offline docs intro#330
gewenyu99 merged 12 commits into
feat-offline-supportfrom
feat-offline-support-intro

Conversation

@gewenyu99

@gewenyu99gewenyu99 commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Intro docs to Offline Support.

stnguyen90
stnguyen90 suggested changes Jan 25, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think the promise thing isn't evident enough, but let's just go with it and adjust accordingly.

Overall, let's call it "Offline Support" instead of just "Offline"

Comment threadapp/views/docs/offline.phtml Outdated
Comment threadapp/views/docs/offline.phtml Outdated
Comment threadapp/views/docs/offline.phtml Outdated
Comment threadapp/views/docs/offline.phtml Outdated
Comment threadapp/views/docs/offline.phtml Outdated
Comment threadapp/views/docs/offline.phtml Outdated
gewenyu99and others added 7 commits January 26, 2023 17:45
@gewenyu99@stnguyen90
Update app/views/docs/offline.phtml
a46cc35
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@gewenyu99@stnguyen90
Update app/views/docs/offline.phtml
a5cf410
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@gewenyu99@stnguyen90
Update app/views/docs/offline.phtml
2cc2599
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@gewenyu99@stnguyen90
Update app/views/docs/offline.phtml
284eab4
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@gewenyu99@stnguyen90
Update app/views/docs/offline.phtml
c84c160
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@gewenyu99@stnguyen90
Update app/views/docs/offline.phtml
4894a13
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@gewenyu99
Rewrite trade offs + existing projects
69e5c82
stnguyen90
stnguyen90 reviewed Feb 4, 2023
View reviewed changes
Comment threadapp/views/docs/offline.phtml Outdated
PineappleIOnic
PineappleIOnic approved these changes Feb 6, 2023
View reviewed changes

@PineappleIOnicPineappleIOnic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from this, everything LGTM 🦭

Comment threadapp/views/docs/offline.phtml Outdated
gewenyu99and others added 2 commits February 6, 2023 11:05
@gewenyu99@PineappleIOnic
Update app/views/docs/offline.phtml
ae66a2b
Co-authored-by: Bradley Schofield <bradley@appwrite.io>
@gewenyu99@stnguyen90
Update app/views/docs/offline.phtml
7ca33c4
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
stnguyen90
stnguyen90 reviewed Feb 8, 2023
View reviewed changes
Comment threadapp/views/docs/offline.phtml Outdated
Comment threadapp/views/docs/offline.phtml Outdated
gewenyu99and others added 2 commits February 10, 2023 13:26
@gewenyu99@stnguyen90
Update app/views/docs/offline.phtml
8c0b39e
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@gewenyu99@stnguyen90
Update app/views/docs/offline.phtml
5828b05
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
@gewenyu99
gewenyu99 merged commit fed9a9f into feat-offline-supportFeb 10, 2023
@gewenyu99
gewenyu99 deleted the feat-offline-support-intro branch February 14, 2023 15:32
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PineappleIOnicPineappleIOnicAwaiting requested review from PineappleIOnic
@stnguyen90stnguyen90Awaiting requested review from stnguyen90

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gewenyu99@stnguyen90@PineappleIOnic