Uh oh!
There was an error while loading. Please reload this page.
Bug(cli): code.tar.gz file remains after error occurs - #99
Conversation
gewenyu99
left a comment
There was a problem hiding this comment.
Hey, could you please clean up the commit and remove all the unnecessary white space type changes so we can find what changed more easily?
Vaibhav91one
commented
Oct 30, 2023
Sure. |
| /* @param {string} entrypoint */ | ||
| /* @param {string} commands */ | ||
| try{ |
There was a problem hiding this comment.
- Let's not have such a big try/catch
- This repo is read-only and the change should be done with the sdk-generator repo.
stnguyen90
commented
Oct 31, 2023
I'm going to add the hacktoberfest-accepted label just so you get credit, but we'll probably close this PR since we need the change in the SDK generator repo. |
gewenyu99
commented
Apr 8, 2024
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
stnguyen90
commented
May 20, 2024
closing as change needs to be done in sdk-generator repo. |
What does this PR do?
Test Plan
N/A
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes