Skip to content

Feature: Sync with meilisearch in bun runtime - #223

Merged
loks0n merged 8 commits into
appwrite:mainfrom
FreSauce:feat-implement-sync-with-meilisearch-bun
Nov 16, 2023
Merged

Feature: Sync with meilisearch in bun runtime#223
loks0n merged 8 commits into
appwrite:mainfrom
FreSauce:feat-implement-sync-with-meilisearch-bun

Conversation

@FreSauce

@FreSauceFreSauce commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a template for Sync With Meilisearch function in bun runtime.

Test Plan

The template demo is deployed here: https://651ef5e34237d8219e7e.appwrite.global/
Test video: https://drive.google.com/file/d/1Zs4uDsRY-XEvX84smaHI3MjGdfYBTEwF/preview

Related PRs and Issues

This is related to Issue #186

Have you read the Contributing Guidelines on issues?

Yes

@FreSauceFreSauce mentioned this pull request Oct 6, 2023
Closed
6 tasks
loks0n
loks0n requested changes Oct 9, 2023
View reviewed changes
Comment threadbun/sync-with-meilisearch/src/utils.ts Outdated
Comment threadbun/sync-with-meilisearch/src/utils.ts Outdated
Comment threadbun/sync-with-meilisearch/src/utils.ts Outdated
Comment threadbun/sync-with-meilisearch/src/utils.ts Outdated
Comment threadbun/sync-with-meilisearch/env.d.ts
@FreSauce
FreSauce requested a review from loks0nOctober 9, 2023 18:55
loks0n
loks0n requested changes Oct 11, 2023
View reviewed changes
Comment threadbun/sync-with-meilisearch/src/main.ts Outdated
Comment threadbun/sync-with-meilisearch/src/utils.ts Outdated
@FreSauce
FreSauce requested a review from loks0nOctober 18, 2023 10:05
loks0n
loks0n requested changes Oct 23, 2023
View reviewed changes
Comment threadbun/sync-with-meilisearch/package.json Outdated
Comment threadbun/sync-with-meilisearch/README.md Outdated
Comment threadbun/sync-with-meilisearch/README.md Outdated
@loks0n

loks0n commented Oct 23, 2023

Copy link
Copy Markdown
Member

Great PR, some small changes required!

@FreSauce

FreSauce commented Oct 23, 2023

Copy link
Copy Markdown
ContributorAuthor

Made the changes, sorry for so many PR review requests.

@FreSauce
FreSauce requested a review from loks0nOctober 23, 2023 14:48
loks0n
loks0n requested changes Oct 26, 2023
View reviewed changes

@loks0nloks0n left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final query :D 🚀

Comment threadbun/sync-with-meilisearch/package.json
Comment on lines +14 to +15
"path": "^0.12.7",
"url": "^0.11.3"

@loks0nloks0nOct 26, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these?
We want to do things the bun way

@loks0n
loks0n self-requested a review October 27, 2023 09:52
@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2023
Closed
@tessamerotessamero linked an issue Nov 2, 2023 that may be closed by this pull request
🚀 Feature: Add Sync with Meilisearch for Bun #186
Closed
6 tasks
@loks0n
loks0n merged commit fddce5d into appwrite:mainNov 16, 2023
@github-actionsgithub-actionsBot mentioned this pull request Dec 1, 2023
Closed
@gewenyu99

gewenyu99 commented Apr 8, 2024

Copy link
Copy Markdown

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@FreSauce

FreSauce commented Apr 10, 2024

Copy link
Copy Markdown
ContributorAuthor

Hey, my discord id is fresauce

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0nloks0nloks0n approved these changes

Assignees

@FreSauceFreSauce

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add Sync with Meilisearch for Bun

3 participants

@FreSauce@loks0n@gewenyu99