Skip to content

feat: sync with meilisearch for ruby - #233

Merged
loks0n merged 6 commits into
appwrite:mainfrom
afzal442:feat-implement-sync-with-meilisearch-ruby
Nov 2, 2023
Merged

feat: sync with meilisearch for ruby#233
loks0n merged 6 commits into
appwrite:mainfrom
afzal442:feat-implement-sync-with-meilisearch-ruby

Conversation

@afzal442

@afzal442afzal442 commented Oct 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes#196

Test Vid:

appwrite_temp_rb.mp4

@loks0n
loks0n self-requested a review October 13, 2023 10:14
loks0n
loks0n requested changes Oct 13, 2023
View reviewed changes

@loks0nloks0n left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've added some comments for you to address

Comment threadruby/meilisearch/config.rb Outdated
Comment threadruby/meilisearch/Gemfile
Comment threadruby/meilisearch/lib/utils.rb
Comment threadruby/meilisearch/lib/main.rb Outdated
@afzal442
afzal442 marked this pull request as draft October 13, 2023 14:38
@afzal442
afzal442 marked this pull request as ready for review October 18, 2023 12:41
@afzal442
afzal442 requested a review from loks0nOctober 18, 2023 12:41
loks0n
loks0n requested changes Oct 23, 2023
View reviewed changes

@loks0nloks0n left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide a test video showing the function executing on Appwrite

Comment threadruby/sync_with_meilisearch/lib/utils.rb
@afzal442
afzal442 requested a review from loks0nOctober 27, 2023 18:56
@afzal442
afzal442force-pushed the feat-implement-sync-with-meilisearch-ruby branch from 5404a34 to b612d9dCompareOctober 27, 2023 19:06
afzal442
afzal442 commented Oct 29, 2023
View reviewed changes
Comment threadruby/sync_with_meilisearch/lib/main.rb Outdated
loks0n
loks0n requested changes Oct 30, 2023
View reviewed changes

@loks0nloks0n left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide a test video showing the function executing on Appwrite

@afzal442

afzal442 commented Oct 31, 2023

Copy link
Copy Markdown
ContributorAuthor

Sorry @loks0n I have been getting this below error. Yesterday, there were no issues, working fine. Any help?

Error 400
Execution error: Server Error
Type
general_argument_invalid

Otherwise, it's working fine.

@afzal442
afzal442 requested a review from loks0nOctober 31, 2023 15:51
@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2023
Closed
@afzal442
afzal442force-pushed the feat-implement-sync-with-meilisearch-ruby branch from 25e8b52 to 4fce47fCompareNovember 2, 2023 08:37
@afzal442

afzal442 commented Nov 2, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hi @loks0n a test video added in the issue desc box. Plz review it.
Link https://653cc78bf40b1c8c8f58.appwrite.global/

@loks0n
loks0n merged commit 6dab35f into appwrite:mainNov 2, 2023
@afzal442
afzal442 deleted the feat-implement-sync-with-meilisearch-ruby branch November 2, 2023 15:40
@github-actionsgithub-actionsBot mentioned this pull request Dec 1, 2023
Closed
@afzal442

afzal442 commented Apr 7, 2024

Copy link
Copy Markdown
ContributorAuthor

my discord id is afzal442

cc @tessamero

@gewenyu99

gewenyu99 commented Apr 19, 2024

Copy link
Copy Markdown

Thanks, be in touch soon!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0nloks0nloks0n approved these changes

Assignees

@afzal442afzal442

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add Sync with Meilisearch for Ruby

3 participants

@afzal442@gewenyu99@loks0n