Skip to content

Issue # 78 | Feature: Add Email Contact Form Function for Java - #235

Open
PalaniappanC wants to merge 2 commits into
appwrite:mainfrom
PalaniappanC:feat-implement-email-contact-form-java
Open

Issue # 78 | Feature: Add Email Contact Form Function for Java#235
PalaniappanC wants to merge 2 commits into
appwrite:mainfrom
PalaniappanC:feat-implement-email-contact-form-java

Conversation

@PalaniappanC

@PalaniappanCPalaniappanC commented Oct 14, 2023

Copy link
Copy Markdown

(#78)

What does this PR do?

Add Email Contact Form Function for Java

Test Plan

video1595354462.mp4

@PalaniappanC

PalaniappanC commented Oct 14, 2023

Copy link
Copy Markdown
Author

Hi folks, I attempted to include HTML files in a separate static folder, but encountered issues accessing them. After seeking advice on the Discord channel, I learned that due to Java being a compiled language, it cannot directly include static and resource files. However, I made an effort to address this by copying the files to the 'src/main/resources' folder within OpenRuntimes, as per Steven's suggestion. Unfortunately, I encountered challenges while doing this. As a workaround, I have added the html content as constant strings.

@loks0n
loks0n self-requested a review October 23, 2023 13:35
loks0n
loks0n requested changes Oct 26, 2023
View reviewed changes

@loks0nloks0n left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR - left some comments

Comment threadjava/email-contact-form/README.md Outdated
Comment threadjava/email-contact-form/src/Cors.java Outdated
Comment threadjava/email-contact-form/src/Cors.java Outdated
Comment threadjava/email-contact-form/src/Cors.java Outdated
Comment threadjava/email-contact-form/src/Cors.java Outdated
Comment threadjava/email-contact-form/src/Utils.java Outdated
Comment threadjava/email-contact-form/src/Main.java Outdated
Comment threadjava/email-contact-form/src/Main.java Outdated
Comment threadjava/email-contact-form/src/Main.java Outdated
Comment threadjava/email-contact-form/src/Main.java Outdated
@PalaniappanC
Issue # 78 | Address reviewer comments
f69e65a
- Remove unwanted imports
_ Remove unwanted error code variable declaration & have it inline
- Refactor javadoc style comments
- Access Origin headers with lowercase "origin"
@PalaniappanC

PalaniappanC commented Oct 26, 2023

Copy link
Copy Markdown
Author

Hi @loks0n Thank you so much for taking time to review my PR. I have pushed the recommended changes.

@loks0n
loks0n requested a review from MeldironOctober 30, 2023 10:01
@loks0n

loks0n commented Oct 30, 2023

Copy link
Copy Markdown
Member

I've added hacktoberfest-accepted we can merge it when the Java runtime has static folder support

@loks0n
loks0n self-requested a review October 30, 2023 10:02
@PalaniappanC

PalaniappanC commented Oct 30, 2023

Copy link
Copy Markdown
Author

Thanks @loks0n

@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2023
Closed
@tessamerotessamero linked an issue Nov 2, 2023 that may be closed by this pull request
🚀 Feature: Add Email Contact Form Function for Java #78
Open
6 tasks
@PalaniappanC

PalaniappanC commented Feb 26, 2024

Copy link
Copy Markdown
Author

Dicord Name for Hacktoberfest communications : palani_13

loks0n
loks0n reviewed Apr 19, 2024
View reviewed changes
Comment threadjava/email-contact-form/src/Utils.java

public class Utils {

static String INDEX_HTML = "<!doctype html><html lang=\"en\"><head><meta charset=\"UTF-8\" /><meta http-equiv=\"X-UA-Compatible\" content=\"IE\" /><meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\" /><title>Email Contact Form</title><link rel=\"stylesheet\" href=\"https://unpkg.com/@appwrite.io/pink\" /><link rel=\"stylesheet\" href=\"https://unpkg.com/@appwrite.io/pink-icons\" /></head><body><main class=\"main-content\"><div class=\"top-cover u-padding-block-end-56\"><div class=\"container\"><div class=\"u-flex u-gap-16 u-flex-justify-center u-margin-block-start-16\"><h1 class=\"heading-level-1\">Contact</h1><code class=\"u-un-break-text\"></code></div><p class=\"body-text-1 u-normal u-margin-block-start-16\" style=\"max-width: 50rem\">Fill the form below to send us a message.</p><form class=\"u-flex-vertical u-gap-16 u-margin-block-start-16\" style=\"max-width: 50rem\" method=\"post\"><input type=\"email\" name=\"email\" placeholder=\"Email\" required /><textarea name=\"message\" placeholder=\"Your Message\" required></textarea><button class=\"button\" type=\"submit\">Submit</button></form></div></div></main></body></html>";

@loks0nloks0nApr 19, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to hold off merging this PR until we have a better solution for this on Open Runtimes

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0nloks0nloks0n approved these changes
@MeldironMeldironMeldiron approved these changes

Assignees

@PalaniappanCPalaniappanC

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add Email Contact Form Function for Java

3 participants

@PalaniappanC@loks0n@Meldiron