Skip to content

#228 - Basic Hello World Slack Command Bot - #236

Merged
loks0n merged 9 commits into
appwrite:mainfrom
ManasMadan:feat-implement-slack-command-bot-node
Nov 24, 2023
Merged

#228 - Basic Hello World Slack Command Bot#236
loks0n merged 9 commits into
appwrite:mainfrom
ManasMadan:feat-implement-slack-command-bot-node

Conversation

@ManasMadan

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR Closes the issue #228 by implementing a Slack Command Bot Template in Node.js

Test Plan

  • I have not changed any code but have written the code in node/slack-command-bot directory.
  • I have tested the code on Appwrite Cloud by creating a function and a Slack Command on Slack.
    Demo Video Link
  • I have made sure the API Verify the Request according to Slack Documentation

Related PRs and Issues

This PR is related to issue #228 and merging this PR closes that issue

Have you read the Contributing Guidelines on issues?

Yes I Have read the contributing guidelines

@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@Haimantika Merging this PR closes issue #228

@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@Haimantika any updates ?

@Haimantika

Copy link
Copy Markdown

@Haimantika any updates ?

I have assigned my team mate. You can also join us for PR reviews tomorrow on Discord and get it reviewed live.

@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@loks0n Any Updates ?

@MeldironMeldiron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid PR ✨ I left some comments to ensure we follow our typical approach to templates. Please address and Ill give it another look

Comment threadnode/slack-command-bot/README.md Outdated
Comment threadnode/slack-command-bot/README.md Outdated
Comment threadnode/slack-command-bot/src/main.js Outdated
Comment threadnode/slack-command-bot/src/main.js Outdated
Comment threadnode/slack-command-bot/package.json Outdated
Comment threadnode/slack-command-bot/src/main.js Outdated
Comment threadnode/slack-command-bot/README.md Outdated
Comment threadnode/slack-command-bot/src/main.js Outdated
Comment threadnode/slack-command-bot/src/main.js Outdated
Comment threadnode/slack-command-bot/src/main.js Outdated
ManasMadanand others added 2 commits October 19, 2023 20:49
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
Co-authored-by: Matej Bačo <matejbaco2000@gmail.com>
@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@Meldiron I will do the changes and let you know.
Thanks !

@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@Meldiron@loks0n I have did all the changes and have tested them Please check
Thanks !

Comment threadnode/slack-command-bot/src/main.js Outdated
Comment threadnode/slack-command-bot/src/main.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/main.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/README.md Outdated
Comment threadnode/slack-command-bot/README.md Outdated
@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@loks0n Have done the changes
Thanks !

Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
@loks0n
loks0n requested a review from MeldironOctober 24, 2023 14:50
@ManasMadan

ManasMadan commented Oct 24, 2023

Copy link
Copy Markdown
ContributorAuthor

@loks0n@Meldiron Please check now have done the changes
Thanks !

@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@loks0n@Meldiron any updates ?

@loks0nloks0n left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a few final things

Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/utils.js Outdated
@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@loks0n have done the changes
Please Check
Thanks !

Comment threadnode/slack-command-bot/src/utils.js Outdated
Comment threadnode/slack-command-bot/src/utils.js
@tessamerotessamero linked an issue Nov 2, 2023 that may be closed by this pull request
6 tasks
@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@Haimantika Am i Eligible for Appwrite Swags ?
If Yes do i need to do something to get them

@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@Meldiron@loks0n can you please merge this

@loks0n

Copy link
Copy Markdown
Member

@Haimantika Am i Eligible for Appwrite Swags ? If Yes do i need to do something to get them

Don't worry - you are eligible for the swags 🥳

We will merge the PR when Meldiron is able to review.

@tessamero

Copy link
Copy Markdown

@ManasMadan add your discord handle here so we can contact you about swags after the PR is merged soon :)

@ManasMadan

Copy link
Copy Markdown
ContributorAuthor

@tessamero My discord username is manasmadan

@loks0n
loks0n merged commit 611ec65 into appwrite:mainNov 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add Slack command bot templates

5 participants

@ManasMadan@Haimantika@loks0n@tessamero@Meldiron