Skip to content

Feat implement database cleaner node - #238

Merged
loks0n merged 61 commits into
appwrite:mainfrom
dishwasher-detergent:feat-implement-database-cleaner-node
Apr 19, 2024
Merged

Feat implement database cleaner node#238
loks0n merged 61 commits into
appwrite:mainfrom
dishwasher-detergent:feat-implement-database-cleaner-node

Conversation

@dishwasher-detergent

@dishwasher-detergentdishwasher-detergent commented Oct 14, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Deletes documents that fall outside of a specified retention period.

Test Plan

I have tested the function template in Appwrite Cloud, you can view that here

Related PRs and Issues

This PR is related to issue #226 and merging this PR closes that issue

Have you read the Contributing Guidelines on issues?

Yes I Have read the contributing guidelines

loks0n
loks0n approved these changes Oct 27, 2023
View reviewed changes
Comment threadnode/database-cleaner/src/utils.js Outdated
export function throwIfMissing(obj, keys) {
const missing = [];
for (let key of keys) {
if (!(key in obj) || obj[key] == null || obj[key] == undefined) {

@loks0nloks0nOct 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition here can just be !(key in obj) || obj[key] == null

@loks0n
loks0n requested a review from MeldironOctober 27, 2023 09:45
@github-actionsgithub-actionsBot mentioned this pull request Nov 1, 2023
Closed
@tessamerotessamero linked an issue Nov 2, 2023 that may be closed by this pull request
🚀 Feature: Add database cleaner templates #226
Closed
6 tasks
@gewenyu99

gewenyu99 commented Apr 8, 2024

Copy link
Copy Markdown

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@dishwasher-detergent

dishwasher-detergent commented Apr 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

Hey! My discord name would be @kennethbass.com. (I am the mod Kenny) :)

@loks0n
loks0n merged commit fe8bed5 into appwrite:mainApr 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MeldironMeldironMeldiron approved these changes
@loks0nloks0nloks0n approved these changes
@gewenyu99gewenyu99Awaiting requested review from gewenyu99

Assignees

@dishwasher-detergentdishwasher-detergent

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add database cleaner templates

4 participants

@dishwasher-detergent@gewenyu99@Meldiron@loks0n