Skip to content

feat: php/whatsapp_with_vonage - #239

Merged
loks0n merged 6 commits into
appwrite:mainfrom
SoNiC-HeRE:feat-implement-whatsapp-with-vonage-php
Oct 26, 2023
Merged

feat: php/whatsapp_with_vonage#239
loks0n merged 6 commits into
appwrite:mainfrom
SoNiC-HeRE:feat-implement-whatsapp-with-vonage-php

Conversation

@SoNiC-HeRE

@SoNiC-HeRESoNiC-HeRE commented Oct 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Added php/whatsapp-with-vonage function template

Test Plan

Record_2023-10-15-20-31-09.mp4
Kooha-2023-10-15-11-09-56.webm

Related PRs and Issues

Close#206

Have you read the Contributing Guidelines on issues?

yes

thinkverse
thinkverse reviewed Oct 16, 2023
View reviewed changes
Comment threadphp/whatsapp-with-vonage/src/index.php
stnguyen90
stnguyen90 suggested changes Oct 17, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

Comment threadphp/whatsapp-with-vonage/src/index.php Outdated
Comment threadphp/whatsapp-with-vonage/src/index.php Outdated
Comment threadphp/whatsapp-with-vonage/src/index.php Outdated
Comment threadphp/whatsapp-with-vonage/src/index.php Outdated
Comment threadphp/whatsapp-with-vonage/src/index.php Outdated
stnguyen90
stnguyen90 reviewed Oct 17, 2023
View reviewed changes
Comment threadphp/whatsapp-with-vonage/composer.json Outdated
@SoNiC-HeRE

SoNiC-HeRE commented Oct 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Changes Made:

  • Used firebase/php-jwt for Jwt verification and payload check
  • Used response codes where necessary
  • Applied consistent styling and indentation
  • Removed extra/unused code

stnguyen90
stnguyen90 reviewed Oct 19, 2023
View reviewed changes
Comment threadphp/whatsapp-with-vonage/src/index.php Outdated
Comment threadphp/whatsapp-with-vonage/src/index.php Outdated
Comment threadphp/whatsapp-with-vonage/src/index.php
@SoNiC-HeRE

SoNiC-HeRE commented Oct 20, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @stnguyen90 , I've addressed the minor changes you suggested and improved the code a bit. Would love to have a final review for this.

stnguyen90
stnguyen90 approved these changes Oct 24, 2023
View reviewed changes

@stnguyen90stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

@loks0n
loks0n merged commit 456687b into appwrite:mainOct 26, 2023
This was referenced Nov 1, 2023
Closed
Closed
@SoNiC-HeRE

SoNiC-HeRE commented Nov 16, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Discord Id:
SnIpEzzz

@gewenyu99

gewenyu99 commented Apr 19, 2024

Copy link
Copy Markdown

Be in touch soon. Putting together some last minute stuff.

@SoNiC-HeRE

SoNiC-HeRE commented Apr 24, 2024

Copy link
Copy Markdown
ContributorAuthor

Be in touch soon. Putting together some last minute stuff.

Please let me know if more details are required. Thanks :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loks0nloks0nloks0n approved these changes
@christyjacob4christyjacob4Awaiting requested review from christyjacob4
+2 more reviewers
@thinkversethinkversethinkverse left review comments
@stnguyen90stnguyen90stnguyen90 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add WhatsApp with Vonage for PHP

5 participants

@SoNiC-HeRE@gewenyu99@stnguyen90@thinkverse@loks0n