Uh oh!
There was an error while loading. Please reload this page.
Refactor Svelte Tutorial - #291
Merged
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adityaoberai
commented
Oct 27, 2023
Contributor
@TGlide have you also had a chance to review the samples here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rewrites portions of the Svelte tutorial. Previously it had some issues, following the tutorial lead to some obstacles (such as errors when trying to access the collections), and encouraged bad practices, such as manipulating a global store server-side.
I've also rewritten certain sections to fit more common Svelte practices, such as using uncontrolled inputs and load functions.