Skip to content

Doc: Removed alt attributes in cards - #303

Merged
TGlide merged 12 commits into
appwrite:mainfrom
Sweetdevil144:main
Nov 6, 2023
Merged

Doc: Removed alt attributes in cards#303
TGlide merged 12 commits into
appwrite:mainfrom
Sweetdevil144:main

Conversation

@Sweetdevil144

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes alt attributes from cards in this section of website.

An empty alt attribute hides the image from assistive technology so it does not add unnecessary noise within the link. Removing the alt attribute would result in the images URL being read out which would make the problem worse!
(Provide a description of what this PR does.)

Related PRs and Issues

Fixes#284
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

Yes
(Write your answer here.)

@vercel

vercelBot commented Oct 30, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
website✅ Ready (Inspect)Visit Preview💬 Add feedbackNov 6, 2023 5:30pm

Comment threadsrc/routes/docs/+page.svelte Outdated
@Sweetdevil144

Copy link
Copy Markdown
ContributorAuthor

@TGlide can you review it?

Comment threadsrc/routes/docs/CodeCard.svelte Outdated

@TGlideTGlide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images seem to be missing:
image

Comment threadsrc/routes/docs/tutorials/+page.svelte Outdated
Comment threadsrc/routes/docs/+page.svelte Outdated

@TGlideTGlide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks great now 🎉

I appreciate the quick responses to my several comments, thank you for the patience and the contribution! 😄

@TGlide
TGlide merged commit df3eef3 into appwrite:mainNov 6, 2023
@gewenyu99

Copy link
Copy Markdown
Contributor

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@Sweetdevil144

Copy link
Copy Markdown
ContributorAuthor

Hey,

Sweetdevil144#8236

Thanks :)

@Sweetdevil144

Copy link
Copy Markdown
ContributorAuthor

@gewenyu99 Updates?

@gewenyu99

Copy link
Copy Markdown
Contributor

@gewenyu99 Updates?

Will reach out soon. Putting some last things together. Appreciate the patience!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📚 Documentation: images in cards should have empty alt attributes [a11y][TheA11y100]

4 participants

@Sweetdevil144@gewenyu99@TGlide@Arindam200