Skip to content

feat: add aria-labels to nav elements - #358

Merged
TGlide merged 7 commits into
appwrite:mainfrom
CBID2:making-nav-more-accessible
Dec 12, 2023
Merged

feat: add aria-labels to nav elements#358
TGlide merged 7 commits into
appwrite:mainfrom
CBID2:making-nav-more-accessible

Conversation

@CBID2

@CBID2CBID2 commented Nov 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds an aria-label to <nav> elements. This to make the site more accessible for users who use screen readers to navigate the site.

Test Plan

To test this, I plan on using an accessiblity chrome extension to see if it conforms to accessibility standards.

Related PRs and Issues

Closes#294

Have you read the Contributing Guidelines on issues?

Yes

@vercel

vercelBot commented Nov 17, 2023

Copy link
Copy Markdown

@CBID2 is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@CBID2
CBID2 marked this pull request as ready for review November 17, 2023 22:13
@CBID2CBID2 mentioned this pull request Nov 17, 2023
Closed
2 tasks
@CBID2
CBID2 marked this pull request as draft November 17, 2023 22:22
TGlide
TGlide suggested changes Nov 21, 2023
View reviewed changes
Comment threadsrc/lib/components/FooterNav.svelte Outdated
Comment threadsrc/lib/layouts/Docs.svelte Outdated
Comment threadsrc/lib/layouts/Main.svelte Outdated
Comment threadsrc/lib/layouts/Sidebar.svelte Outdated
Comment threadsrc/markdoc/tags/Tabs.svelte Outdated
@TGlide

TGlide commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

@CBID2 Thank you for the PR!! I left a few comments 🙂

@CBID2
CBID2 marked this pull request as ready for review November 21, 2023 19:10
@CBID2

CBID2 commented Nov 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @TGlide! :) I made the changes you suggested! :)

TGlide
TGlide reviewed Nov 23, 2023
View reviewed changes
Comment threadsrc/markdoc/tags/Tabs.svelte
</script>

<div class="aw-card is-normal u-margin-block-start-16" {...$root} use:root>
<nav class="tabs u-flex u-gap-16">

@TGlideTGlideNov 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my wording was off here. By removing the nav element, I meant swapping it with something else, e.g. a div. Otherwise we lose the styling we had here.

@CBID2

CBID2 commented Nov 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Hi @TGlide! :) I made the changes! :)

@CBID2
CBID2 requested a review from TGlideNovember 29, 2023 21:42
@github-actionsgithub-actionsBot mentioned this pull request Dec 1, 2023
Closed
TGlide
TGlide approved these changes Dec 12, 2023
View reviewed changes

@TGlideTGlide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😄

@TGlide
TGlide merged commit e1724f8 into appwrite:mainDec 12, 2023
@CBID2
CBID2 deleted the making-nav-more-accessible branch December 12, 2023 20:51
@github-actionsgithub-actionsBot mentioned this pull request Jan 1, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@TGlideTGlideTGlide approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

📚 Documentation: multiple <nav> elements should be labelled [a11y][TheA11y100]

2 participants

@CBID2@TGlide