Skip to content

Fix formatting & add endpoints to refereneces - #382

Merged
TGlide merged 8 commits into
mainfrom
fix-formatting
Dec 18, 2023
Merged

Fix formatting & add endpoints to refereneces#382
TGlide merged 8 commits into
mainfrom
fix-formatting

Conversation

@TGlide

@TGlideTGlide commented Nov 23, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@TGlideTGlide self-assigned this Nov 23, 2023
@render

renderBot commented Nov 23, 2023

Copy link
Copy Markdown

Your Render PR Server URL is https://appwrite-pr-382.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-clfofl6f27hc73a8isu0.

@vercel

vercelBot commented Nov 23, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
website✅ Ready (Inspect)Visit Preview💬 Add feedbackDec 18, 2023 3:19pm

TorstenDittmann
TorstenDittmann approved these changes Nov 23, 2023
View reviewed changes

@TorstenDittmannTorstenDittmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure it goes through a design review 👍🏻

Comment threadsrc/lib/utils/specs.ts Outdated
Comment threadsrc/lib/utils/specs.ts Outdated
@eldadfux

eldadfux commented Nov 23, 2023

Copy link
Copy Markdown
Member

Reminder to add some padding between the sticky top border and the path code block

@eldadfux

eldadfux commented Nov 23, 2023

Copy link
Copy Markdown
Member

We're also missing the /v1/ prefix for the paths.

gewenyu99
gewenyu99 approved these changes Nov 23, 2023
View reviewed changes

@gewenyu99gewenyu99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice <3

Maybe address should be on the left tbh, let's talk about this with Chen later.

gewenyu99
gewenyu99 suggested changes Nov 30, 2023
View reviewed changes

@gewenyu99gewenyu99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TGlide Check Asana, there are some changes Chen asked for :)

@github-actionsgithub-actionsBot mentioned this pull request Dec 1, 2023
Closed
@gewenyu99

gewenyu99 commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

image
One last comment, can we make the copy button here select only the path not the method?

Copy /getAccount vs GET /getAccount as a figurative example.

gewenyu99
gewenyu99 approved these changes Dec 18, 2023
View reviewed changes

@gewenyu99gewenyu99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comment about copy, if that's difficult/not possible right now, we can merge this as is.

@gewenyu99

gewenyu99 commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

LGTM, paste is fixed

@TGlide
TGlide merged commit bd282cb into mainDec 18, 2023
@github-actionsgithub-actionsBot mentioned this pull request Jan 1, 2024
Closed
@adityaoberai
adityaoberai deleted the fix-formatting branch August 22, 2024 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmannTorstenDittmannTorstenDittmann approved these changes
+1 more reviewer
@gewenyu99gewenyu99gewenyu99 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TGlideTGlide

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TGlide@eldadfux@gewenyu99@TorstenDittmann