Skip to content

fix: grammar mistakes - #552

Merged
loks0n merged 4 commits into
appwrite:mainfrom
thisislvca:main
May 7, 2024
Merged

fix: grammar mistakes#552
loks0n merged 4 commits into
appwrite:mainfrom
thisislvca:main

Conversation

@thisislvca

Copy link
Copy Markdown
Contributor

What does this PR do?

Ths PR fixes some grammar mistakes I saw while reading through appwrite's docs. There are more dotted around, but I just fixed the few I saw myself :)

Test Plan

Not needed.

Related PRs and Issues

None.

Have you read the Contributing Guidelines on issues?

Yes

gewenyu99
gewenyu99 previously requested changes Jan 26, 2024

@gewenyu99gewenyu99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR, there's just one thing, we don't use : colons before lists as a stylistic choice.

You can also reach us at `privacy@appwrite.io` for more questions.

Appwrite has also implemented the following security measures to achieve technical compliance.
Appwrite has also implemented the following security measures to achieve technical compliance:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you do it at line 10 of that same file... :)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But can remove both if you want

@thisislvca

Copy link
Copy Markdown
ContributorAuthor

Yo boys I actually fixed it so now it should be ready to get merged :)

@loks0n
loks0n self-requested a review May 7, 2024 11:27
@loks0n
loks0n merged commit acc39d5 into appwrite:mainMay 7, 2024
@loks0n

Copy link
Copy Markdown
Member

Yo boys I actually fixed it so now it should be ready to get merged :)

Thanks for your contribution 🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thisislvca@loks0n@gewenyu99