') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Feature: Add CONTRIBUYENDO document by jcstr · Pull Request #13 · archlinuxmx/archlinuxmx.github.io · GitHub
Skip to content

Feature: Add CONTRIBUYENDO document - #13

Open
jcstr wants to merge 3 commits into
mainfrom
add-doc-contributing
Open

Feature: Add CONTRIBUYENDO document#13
jcstr wants to merge 3 commits into
mainfrom
add-doc-contributing

Conversation

@jcstr

@jcstrjcstr commented Nov 10, 2020

Copy link
Copy Markdown
Member

  1. Why is this change neccesary?
    This change adds the document that will serve as a reference for the new
    contributors.

  2. How does it address the issue?
    By adding CONTRIBUYENDO.md document to the repository.

  3. What side effects does this change have?
    None.

@jcstr
Feature: Add CONTRIBUYENDO document
b675e41
1. Why is this change neccesary?
This change adds the document that will serve as a reference for the new
contributors.
2. How does it address the issue?
By adding CONTRIBUYENDO.md document to the repository.
3. What side effects does this change have?
None.
@jcstrjcstr added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 10, 2020
@jcstrjcstr added this to the Versión inicial milestone Nov 10, 2020
@jcstrjcstr self-assigned this Nov 10, 2020
@jcstrjcstr linked an issue Nov 10, 2020 that may be closed by this pull request
Crear documentación para contribuidores #12
Open
denisse-dev
denisse-dev approved these changes Nov 10, 2020
View reviewed changes

@denisse-devdenisse-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images - 2020-11-10T173053 440

SantiagoTorres
SantiagoTorres reviewed Nov 11, 2020
View reviewed changes
Comment threadCONTRIBUYENDO.md Outdated
Nos gustaría que usaras el template de [Andrea Gómez](https://github.com/da-edra/dotfiles/blob/master/.gitmessage) para el mensaje del commit.

# Gracias por leer este documento
Ya que haz llegado al final de este documento nos gustaría agradecerte por tomarte el tiempo de leerlo y con gusto estamos dispuestas y dispuestos a ayudarte.

@SantiagoTorresSantiagoTorresNov 11, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/haz/has/ no?

@jcstrjcstrNov 11, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listo, corregido 😄

@SantiagoTorres

SantiagoTorres commented Nov 11, 2020

Copy link
Copy Markdown

Hmm el deploy esta fallando, pero este PR no toca nada que tenga que ver con el deploy...

@jcstr

jcstr commented Nov 11, 2020

Copy link
Copy Markdown
MemberAuthor

@SantiagoTorres La razón por la cual falla es que no encuentra el tema en la carpeta themes, ademas de que se descartó el tema por que ya no se le ha estado dando mantenimiento desde hace poco más de un año. Se trabajará en otro tema más nuevo 😄

$ hugo
7:43:36 PM: Error: Unable to find theme Directory: /opt/build/repo/themes/arch

@denisse-dev

denisse-dev commented Nov 12, 2020

Copy link
Copy Markdown
Member

Sí, disculpen que el deploy esté fallando, me encuentro trabajando en ello. :)

@denisse-dev

denisse-dev commented Nov 12, 2020

Copy link
Copy Markdown
Member

Creo que estaría mejor poner el template de commit aquí y no vincularlo a mi perfil, también creo que quizá podríamos simplemente pedir que el título tenga como prefijo el tipo de cambio que realiza el commit ergo feature/ o fix/, qué opinan?

@jcstr

jcstr commented Nov 12, 2020

Copy link
Copy Markdown
MemberAuthor

@da-edra estoy de acuerdo con lo que mencionas, me dejé llevar por el template que compartiste :D

Ahora mismo me encargo de agregar el template del mensaje del commit aquí y corrijo la sección de los prefijos.

@denisse-dev

denisse-dev commented Nov 12, 2020

Copy link
Copy Markdown
Member

Muchas gracias @jcstr ! :D

Yo sugeriría simplemente mencionar que sería preferible que su commit contenga como prefijo feature/fix/, etc. Aunque amo mi template de commits porque es bastante útil creo que podría ser tedioso para las personas que quieran contribuir tener que apegarse a ella, de igual manera creo que podríamos tener mejor una plantilla de Pull Requests (#16 ) que podría ser de bastante utilidad cuando la gente quiera contribuir al proyecto. Qué opinan?

@jcstr

jcstr commented Nov 24, 2020

Copy link
Copy Markdown
MemberAuthor

Listo @da-edra agregue los cambios necesarios, ya esta actualizado el PR. Sólo queda agregar los cambios y listo :D

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SantiagoTorresSantiagoTorresSantiagoTorres approved these changes
@denisse-devdenisse-devdenisse-dev approved these changes

Assignees

@jcstrjcstr

Labels

documentationImprovements or additions to documentationenhancementNew feature or request

Projects

None yet

Milestone

Versión inicial

Development

Successfully merging this pull request may close these issues.

Crear documentación para contribuidores

3 participants

@jcstr@SantiagoTorres@denisse-dev