ICacheSpecificationBuilder

[vittorelli]

A small change to the SpecificationBuilderExtensions.EnableCache builder method in order to allow developers to create their own extension methods for customized caching implementations.

I've been using Spefications throughout several different projects and am a huge fan. We've recently added support for caching in our repositories and I've refactored the code so it integrates with Specification. A requirement in our project was to have some expiration date on the cache, which isn't possible with the current method signatures. I saw two possibilities:

1. Create additional methods/overloads/... in Ardalis.Specification that allow for adding information on how the caching should behave.
2. Minimal intrusion in Ardalis.Specification by changing the return type of SpecificationBuilderExtensions.EnableCache.

The liked the first option better, but soon realised that my requirements wouldn't nessecarily match those of other developers, and I didn't like the idea of creating too many new methods to support different needs in caching behaviour (absolute expiration, sliding windows, tokens, ....).

So I've gone with the second possibility.
The main idea of this pull request is to constrain the usage of extension methods one may create to facilitate custom caching needs in projects that consume Ardalis.Specification. This idea might also be extended to other builder methods.

What do you guys think?

Example on how I'm using the ICacheSpecificationBuilder

publicstaticclassCachedSpecificationExtensions{privatestaticConcurrentDictionary<string,TimeSpan>_expirationTimeSpans=new();/// <summary>/// Extension method which registers cache TTL values for the <see cref="Ardalis.Specification"/> on/// which this method is called./// </summary>publicstaticISpecificationBuilder<T>WithCacheExpiration<T>(thisICacheSpecificationBuilder<T>@this,TimeSpanspan)whereT:class{_expirationTimeSpans[@this.Specification.CacheKey]=span;return@this;}/// <summary>/// Utility method which can be used in repositories to read registered TTL values./// </summary>/// <param name="key"></param>publicstaticTimeSpanGetTimeSpan(stringkey){return_expirationTimeSpans.ContainsKey(key)?_expirationTimeSpans[key]:TimeSpan.MaxValue;}}/// <summary>/// Example specification using <see cref="SpecificationExtentions.WithCacheExpiration{T}(ICacheSpecificationBuilder{T}, TimeSpan)"/>./// </summary>publicclassCachedEntityListSpecification:Specification<Entity>{publicCachedEntityListSpecification(stringcolor){Query.EnableCache(nameof(CachedEntityListSpecification),"filter_color",color).WithCacheExpiration(TimeSpan.FromHours(12)).Where(x =>x.Color==color);}}/// <summary>/// Example Entity class./// </summary>publicclassEntity{publicstringName{get;set;}publicstringColor{get;set;}}/// <summary>/// Example Repository/// </summary>publicclassRepository<T>{privateDbContext_ctx;privateMemoryCache_cache;publicList<T>List(ISpecification<T>spec){varspecificationResult=SpecificationEvaluator.Default.GetQuery(_ctx.Set<T>().AsQueryable(),spec);if(spec.CacheEnabled){varttl=CachedSpecificationExtensions.GetTimeSpan(spec.CacheKey);_cache.GetOrCreate(spec.CacheKey, ce =>{ce.AbsoluteExpiration=DateTime.Now.Add(ttl);returnspecificationResult.ToList();});}else{returnspecificationResult.ToList();}}}

[fiseni]

Hi @vittorelli,

Thank you. I do like this. We're not including anything specific, but we're providing a mechanism for users to handle it by themselves.

Your usage is nice too. To be honest, keeping app-wide mutable shared state is always fishy :) Yea, the concurrent dictionary is considered thread-safe, but not all methods. Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

@ardalis if you don't have any comments, let's merge this.

[vittorelli]

Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

Don't know why I didn't think of that. Way better, thanks! :-)

[ardalis]

I love it; let's do it! Any chance we can get a docs PR with some usage examples, too?

[vittorelli]

I'll see what I can do about the docs :-)

[vittorelli]

A small change to the SpecificationBuilderExtensions.EnableCache builder method in order to allow developers to create their own extension methods for customized caching implementations.

I've been using Spefications throughout several different projects and am a huge fan. We've recently added support for caching in our repositories and I've refactored the code so it integrates with Specification. A requirement in our project was to have some expiration date on the cache, which isn't possible with the current method signatures. I saw two possibilities:

1. Create additional methods/overloads/... in Ardalis.Specification that allow for adding information on how the caching should behave.
2. Minimal intrusion in Ardalis.Specification by changing the return type of SpecificationBuilderExtensions.EnableCache.

The liked the first option better, but soon realised that my requirements wouldn't nessecarily match those of other developers, and I didn't like the idea of creating too many new methods to support different needs in caching behaviour (absolute expiration, sliding windows, tokens, ....).

So I've gone with the second possibility.
The main idea of this pull request is to constrain the usage of extension methods one may create to facilitate custom caching needs in projects that consume Ardalis.Specification. This idea might also be extended to other builder methods.

What do you guys think?

Example on how I'm using the ICacheSpecificationBuilder

publicstaticclassCachedSpecificationExtensions{privatestaticConcurrentDictionary<string,TimeSpan>_expirationTimeSpans=new();/// <summary>/// Extension method which registers cache TTL values for the <see cref="Ardalis.Specification"/> on/// which this method is called./// </summary>publicstaticISpecificationBuilder<T>WithCacheExpiration<T>(thisICacheSpecificationBuilder<T>@this,TimeSpanspan)whereT:class{_expirationTimeSpans[@this.Specification.CacheKey]=span;return@this;}/// <summary>/// Utility method which can be used in repositories to read registered TTL values./// </summary>/// <param name="key"></param>publicstaticTimeSpanGetTimeSpan(stringkey){return_expirationTimeSpans.ContainsKey(key)?_expirationTimeSpans[key]:TimeSpan.MaxValue;}}/// <summary>/// Example specification using <see cref="SpecificationExtentions.WithCacheExpiration{T}(ICacheSpecificationBuilder{T}, TimeSpan)"/>./// </summary>publicclassCachedEntityListSpecification:Specification<Entity>{publicCachedEntityListSpecification(stringcolor){Query.EnableCache(nameof(CachedEntityListSpecification),"filter_color",color).WithCacheExpiration(TimeSpan.FromHours(12)).Where(x =>x.Color==color);}}/// <summary>/// Example Entity class./// </summary>publicclassEntity{publicstringName{get;set;}publicstringColor{get;set;}}/// <summary>/// Example Repository/// </summary>publicclassRepository<T>{privateDbContext_ctx;privateMemoryCache_cache;publicList<T>List(ISpecification<T>spec){varspecificationResult=SpecificationEvaluator.Default.GetQuery(_ctx.Set<T>().AsQueryable(),spec);if(spec.CacheEnabled){varttl=CachedSpecificationExtensions.GetTimeSpan(spec.CacheKey);_cache.GetOrCreate(spec.CacheKey, ce =>{ce.AbsoluteExpiration=DateTime.Now.Add(ttl);returnspecificationResult.ToList();});}else{returnspecificationResult.ToList();}}}

[fiseni]

Hi @vittorelli,

Thank you. I do like this. We're not including anything specific, but we're providing a mechanism for users to handle it by themselves.

Your usage is nice too. To be honest, keeping app-wide mutable shared state is always fishy :) Yea, the concurrent dictionary is considered thread-safe, but not all methods. Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

@ardalis if you don't have any comments, let's merge this.

[vittorelli]

Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

Don't know why I didn't think of that. Way better, thanks! :-)

[ardalis]

I love it; let's do it! Any chance we can get a docs PR with some usage examples, too?

[vittorelli]

I'll see what I can do about the docs :-)

[vittorelli]

A small change to the SpecificationBuilderExtensions.EnableCache builder method in order to allow developers to create their own extension methods for customized caching implementations.

I've been using Spefications throughout several different projects and am a huge fan. We've recently added support for caching in our repositories and I've refactored the code so it integrates with Specification. A requirement in our project was to have some expiration date on the cache, which isn't possible with the current method signatures. I saw two possibilities:

1. Create additional methods/overloads/... in Ardalis.Specification that allow for adding information on how the caching should behave.
2. Minimal intrusion in Ardalis.Specification by changing the return type of SpecificationBuilderExtensions.EnableCache.

The liked the first option better, but soon realised that my requirements wouldn't nessecarily match those of other developers, and I didn't like the idea of creating too many new methods to support different needs in caching behaviour (absolute expiration, sliding windows, tokens, ....).

So I've gone with the second possibility.
The main idea of this pull request is to constrain the usage of extension methods one may create to facilitate custom caching needs in projects that consume Ardalis.Specification. This idea might also be extended to other builder methods.

What do you guys think?

Example on how I'm using the ICacheSpecificationBuilder

publicstaticclassCachedSpecificationExtensions{privatestaticConcurrentDictionary<string,TimeSpan>_expirationTimeSpans=new();/// <summary>/// Extension method which registers cache TTL values for the <see cref="Ardalis.Specification"/> on/// which this method is called./// </summary>publicstaticISpecificationBuilder<T>WithCacheExpiration<T>(thisICacheSpecificationBuilder<T>@this,TimeSpanspan)whereT:class{_expirationTimeSpans[@this.Specification.CacheKey]=span;return@this;}/// <summary>/// Utility method which can be used in repositories to read registered TTL values./// </summary>/// <param name="key"></param>publicstaticTimeSpanGetTimeSpan(stringkey){return_expirationTimeSpans.ContainsKey(key)?_expirationTimeSpans[key]:TimeSpan.MaxValue;}}/// <summary>/// Example specification using <see cref="SpecificationExtentions.WithCacheExpiration{T}(ICacheSpecificationBuilder{T}, TimeSpan)"/>./// </summary>publicclassCachedEntityListSpecification:Specification<Entity>{publicCachedEntityListSpecification(stringcolor){Query.EnableCache(nameof(CachedEntityListSpecification),"filter_color",color).WithCacheExpiration(TimeSpan.FromHours(12)).Where(x =>x.Color==color);}}/// <summary>/// Example Entity class./// </summary>publicclassEntity{publicstringName{get;set;}publicstringColor{get;set;}}/// <summary>/// Example Repository/// </summary>publicclassRepository<T>{privateDbContext_ctx;privateMemoryCache_cache;publicList<T>List(ISpecification<T>spec){varspecificationResult=SpecificationEvaluator.Default.GetQuery(_ctx.Set<T>().AsQueryable(),spec);if(spec.CacheEnabled){varttl=CachedSpecificationExtensions.GetTimeSpan(spec.CacheKey);_cache.GetOrCreate(spec.CacheKey, ce =>{ce.AbsoluteExpiration=DateTime.Now.Add(ttl);returnspecificationResult.ToList();});}else{returnspecificationResult.ToList();}}}

[fiseni]

Hi @vittorelli,

Thank you. I do like this. We're not including anything specific, but we're providing a mechanism for users to handle it by themselves.

Your usage is nice too. To be honest, keeping app-wide mutable shared state is always fishy :) Yea, the concurrent dictionary is considered thread-safe, but not all methods. Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

@ardalis if you don't have any comments, let's merge this.

[vittorelli]

Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

Don't know why I didn't think of that. Way better, thanks! :-)

[ardalis]

I love it; let's do it! Any chance we can get a docs PR with some usage examples, too?

[vittorelli]

I'll see what I can do about the docs :-)

[vittorelli]

A small change to the SpecificationBuilderExtensions.EnableCache builder method in order to allow developers to create their own extension methods for customized caching implementations.

I've been using Spefications throughout several different projects and am a huge fan. We've recently added support for caching in our repositories and I've refactored the code so it integrates with Specification. A requirement in our project was to have some expiration date on the cache, which isn't possible with the current method signatures. I saw two possibilities:

1. Create additional methods/overloads/... in Ardalis.Specification that allow for adding information on how the caching should behave.
2. Minimal intrusion in Ardalis.Specification by changing the return type of SpecificationBuilderExtensions.EnableCache.

The liked the first option better, but soon realised that my requirements wouldn't nessecarily match those of other developers, and I didn't like the idea of creating too many new methods to support different needs in caching behaviour (absolute expiration, sliding windows, tokens, ....).

So I've gone with the second possibility.
The main idea of this pull request is to constrain the usage of extension methods one may create to facilitate custom caching needs in projects that consume Ardalis.Specification. This idea might also be extended to other builder methods.

What do you guys think?

Example on how I'm using the ICacheSpecificationBuilder

publicstaticclassCachedSpecificationExtensions{privatestaticConcurrentDictionary<string,TimeSpan>_expirationTimeSpans=new();/// <summary>/// Extension method which registers cache TTL values for the <see cref="Ardalis.Specification"/> on/// which this method is called./// </summary>publicstaticISpecificationBuilder<T>WithCacheExpiration<T>(thisICacheSpecificationBuilder<T>@this,TimeSpanspan)whereT:class{_expirationTimeSpans[@this.Specification.CacheKey]=span;return@this;}/// <summary>/// Utility method which can be used in repositories to read registered TTL values./// </summary>/// <param name="key"></param>publicstaticTimeSpanGetTimeSpan(stringkey){return_expirationTimeSpans.ContainsKey(key)?_expirationTimeSpans[key]:TimeSpan.MaxValue;}}/// <summary>/// Example specification using <see cref="SpecificationExtentions.WithCacheExpiration{T}(ICacheSpecificationBuilder{T}, TimeSpan)"/>./// </summary>publicclassCachedEntityListSpecification:Specification<Entity>{publicCachedEntityListSpecification(stringcolor){Query.EnableCache(nameof(CachedEntityListSpecification),"filter_color",color).WithCacheExpiration(TimeSpan.FromHours(12)).Where(x =>x.Color==color);}}/// <summary>/// Example Entity class./// </summary>publicclassEntity{publicstringName{get;set;}publicstringColor{get;set;}}/// <summary>/// Example Repository/// </summary>publicclassRepository<T>{privateDbContext_ctx;privateMemoryCache_cache;publicList<T>List(ISpecification<T>spec){varspecificationResult=SpecificationEvaluator.Default.GetQuery(_ctx.Set<T>().AsQueryable(),spec);if(spec.CacheEnabled){varttl=CachedSpecificationExtensions.GetTimeSpan(spec.CacheKey);_cache.GetOrCreate(spec.CacheKey, ce =>{ce.AbsoluteExpiration=DateTime.Now.Add(ttl);returnspecificationResult.ToList();});}else{returnspecificationResult.ToList();}}}

[fiseni]

Hi @vittorelli,

Thank you. I do like this. We're not including anything specific, but we're providing a mechanism for users to handle it by themselves.

Your usage is nice too. To be honest, keeping app-wide mutable shared state is always fishy :) Yea, the concurrent dictionary is considered thread-safe, but not all methods. Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

@ardalis if you don't have any comments, let's merge this.

[vittorelli]

Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

Don't know why I didn't think of that. Way better, thanks! :-)

[ardalis]

I love it; let's do it! Any chance we can get a docs PR with some usage examples, too?

[vittorelli]

I'll see what I can do about the docs :-)

[vittorelli]

A small change to the SpecificationBuilderExtensions.EnableCache builder method in order to allow developers to create their own extension methods for customized caching implementations.

I've been using Spefications throughout several different projects and am a huge fan. We've recently added support for caching in our repositories and I've refactored the code so it integrates with Specification. A requirement in our project was to have some expiration date on the cache, which isn't possible with the current method signatures. I saw two possibilities:

1. Create additional methods/overloads/... in Ardalis.Specification that allow for adding information on how the caching should behave.
2. Minimal intrusion in Ardalis.Specification by changing the return type of SpecificationBuilderExtensions.EnableCache.

The liked the first option better, but soon realised that my requirements wouldn't nessecarily match those of other developers, and I didn't like the idea of creating too many new methods to support different needs in caching behaviour (absolute expiration, sliding windows, tokens, ....).

So I've gone with the second possibility.
The main idea of this pull request is to constrain the usage of extension methods one may create to facilitate custom caching needs in projects that consume Ardalis.Specification. This idea might also be extended to other builder methods.

What do you guys think?

Example on how I'm using the ICacheSpecificationBuilder

publicstaticclassCachedSpecificationExtensions{privatestaticConcurrentDictionary<string,TimeSpan>_expirationTimeSpans=new();/// <summary>/// Extension method which registers cache TTL values for the <see cref="Ardalis.Specification"/> on/// which this method is called./// </summary>publicstaticISpecificationBuilder<T>WithCacheExpiration<T>(thisICacheSpecificationBuilder<T>@this,TimeSpanspan)whereT:class{_expirationTimeSpans[@this.Specification.CacheKey]=span;return@this;}/// <summary>/// Utility method which can be used in repositories to read registered TTL values./// </summary>/// <param name="key"></param>publicstaticTimeSpanGetTimeSpan(stringkey){return_expirationTimeSpans.ContainsKey(key)?_expirationTimeSpans[key]:TimeSpan.MaxValue;}}/// <summary>/// Example specification using <see cref="SpecificationExtentions.WithCacheExpiration{T}(ICacheSpecificationBuilder{T}, TimeSpan)"/>./// </summary>publicclassCachedEntityListSpecification:Specification<Entity>{publicCachedEntityListSpecification(stringcolor){Query.EnableCache(nameof(CachedEntityListSpecification),"filter_color",color).WithCacheExpiration(TimeSpan.FromHours(12)).Where(x =>x.Color==color);}}/// <summary>/// Example Entity class./// </summary>publicclassEntity{publicstringName{get;set;}publicstringColor{get;set;}}/// <summary>/// Example Repository/// </summary>publicclassRepository<T>{privateDbContext_ctx;privateMemoryCache_cache;publicList<T>List(ISpecification<T>spec){varspecificationResult=SpecificationEvaluator.Default.GetQuery(_ctx.Set<T>().AsQueryable(),spec);if(spec.CacheEnabled){varttl=CachedSpecificationExtensions.GetTimeSpan(spec.CacheKey);_cache.GetOrCreate(spec.CacheKey, ce =>{ce.AbsoluteExpiration=DateTime.Now.Add(ttl);returnspecificationResult.ToList();});}else{returnspecificationResult.ToList();}}}

[fiseni]

Hi @vittorelli,

Thank you. I do like this. We're not including anything specific, but we're providing a mechanism for users to handle it by themselves.

Your usage is nice too. To be honest, keeping app-wide mutable shared state is always fishy :) Yea, the concurrent dictionary is considered thread-safe, but not all methods. Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

@ardalis if you don't have any comments, let's merge this.

[vittorelli]

Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

Don't know why I didn't think of that. Way better, thanks! :-)

[ardalis]

I love it; let's do it! Any chance we can get a docs PR with some usage examples, too?

[vittorelli]

I'll see what I can do about the docs :-)

[vittorelli]

A small change to the SpecificationBuilderExtensions.EnableCache builder method in order to allow developers to create their own extension methods for customized caching implementations.

I've been using Spefications throughout several different projects and am a huge fan. We've recently added support for caching in our repositories and I've refactored the code so it integrates with Specification. A requirement in our project was to have some expiration date on the cache, which isn't possible with the current method signatures. I saw two possibilities:

1. Create additional methods/overloads/... in Ardalis.Specification that allow for adding information on how the caching should behave.
2. Minimal intrusion in Ardalis.Specification by changing the return type of SpecificationBuilderExtensions.EnableCache.

The liked the first option better, but soon realised that my requirements wouldn't nessecarily match those of other developers, and I didn't like the idea of creating too many new methods to support different needs in caching behaviour (absolute expiration, sliding windows, tokens, ....).

So I've gone with the second possibility.
The main idea of this pull request is to constrain the usage of extension methods one may create to facilitate custom caching needs in projects that consume Ardalis.Specification. This idea might also be extended to other builder methods.

What do you guys think?

Example on how I'm using the ICacheSpecificationBuilder

publicstaticclassCachedSpecificationExtensions{privatestaticConcurrentDictionary<string,TimeSpan>_expirationTimeSpans=new();/// <summary>/// Extension method which registers cache TTL values for the <see cref="Ardalis.Specification"/> on/// which this method is called./// </summary>publicstaticISpecificationBuilder<T>WithCacheExpiration<T>(thisICacheSpecificationBuilder<T>@this,TimeSpanspan)whereT:class{_expirationTimeSpans[@this.Specification.CacheKey]=span;return@this;}/// <summary>/// Utility method which can be used in repositories to read registered TTL values./// </summary>/// <param name="key"></param>publicstaticTimeSpanGetTimeSpan(stringkey){return_expirationTimeSpans.ContainsKey(key)?_expirationTimeSpans[key]:TimeSpan.MaxValue;}}/// <summary>/// Example specification using <see cref="SpecificationExtentions.WithCacheExpiration{T}(ICacheSpecificationBuilder{T}, TimeSpan)"/>./// </summary>publicclassCachedEntityListSpecification:Specification<Entity>{publicCachedEntityListSpecification(stringcolor){Query.EnableCache(nameof(CachedEntityListSpecification),"filter_color",color).WithCacheExpiration(TimeSpan.FromHours(12)).Where(x =>x.Color==color);}}/// <summary>/// Example Entity class./// </summary>publicclassEntity{publicstringName{get;set;}publicstringColor{get;set;}}/// <summary>/// Example Repository/// </summary>publicclassRepository<T>{privateDbContext_ctx;privateMemoryCache_cache;publicList<T>List(ISpecification<T>spec){varspecificationResult=SpecificationEvaluator.Default.GetQuery(_ctx.Set<T>().AsQueryable(),spec);if(spec.CacheEnabled){varttl=CachedSpecificationExtensions.GetTimeSpan(spec.CacheKey);_cache.GetOrCreate(spec.CacheKey, ce =>{ce.AbsoluteExpiration=DateTime.Now.Add(ttl);returnspecificationResult.ToList();});}else{returnspecificationResult.ToList();}}}

[fiseni]

Hi @vittorelli,

Thank you. I do like this. We're not including anything specific, but we're providing a mechanism for users to handle it by themselves.

Your usage is nice too. To be honest, keeping app-wide mutable shared state is always fishy :) Yea, the concurrent dictionary is considered thread-safe, but not all methods. Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

@ardalis if you don't have any comments, let's merge this.

[vittorelli]

Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

Don't know why I didn't think of that. Way better, thanks! :-)

[ardalis]

I love it; let's do it! Any chance we can get a docs PR with some usage examples, too?

[vittorelli]

I'll see what I can do about the docs :-)

[vittorelli]

A small change to the SpecificationBuilderExtensions.EnableCache builder method in order to allow developers to create their own extension methods for customized caching implementations.

I've been using Spefications throughout several different projects and am a huge fan. We've recently added support for caching in our repositories and I've refactored the code so it integrates with Specification. A requirement in our project was to have some expiration date on the cache, which isn't possible with the current method signatures. I saw two possibilities:

1. Create additional methods/overloads/... in Ardalis.Specification that allow for adding information on how the caching should behave.
2. Minimal intrusion in Ardalis.Specification by changing the return type of SpecificationBuilderExtensions.EnableCache.

The liked the first option better, but soon realised that my requirements wouldn't nessecarily match those of other developers, and I didn't like the idea of creating too many new methods to support different needs in caching behaviour (absolute expiration, sliding windows, tokens, ....).

So I've gone with the second possibility.
The main idea of this pull request is to constrain the usage of extension methods one may create to facilitate custom caching needs in projects that consume Ardalis.Specification. This idea might also be extended to other builder methods.

What do you guys think?

Example on how I'm using the ICacheSpecificationBuilder

publicstaticclassCachedSpecificationExtensions{privatestaticConcurrentDictionary<string,TimeSpan>_expirationTimeSpans=new();/// <summary>/// Extension method which registers cache TTL values for the <see cref="Ardalis.Specification"/> on/// which this method is called./// </summary>publicstaticISpecificationBuilder<T>WithCacheExpiration<T>(thisICacheSpecificationBuilder<T>@this,TimeSpanspan)whereT:class{_expirationTimeSpans[@this.Specification.CacheKey]=span;return@this;}/// <summary>/// Utility method which can be used in repositories to read registered TTL values./// </summary>/// <param name="key"></param>publicstaticTimeSpanGetTimeSpan(stringkey){return_expirationTimeSpans.ContainsKey(key)?_expirationTimeSpans[key]:TimeSpan.MaxValue;}}/// <summary>/// Example specification using <see cref="SpecificationExtentions.WithCacheExpiration{T}(ICacheSpecificationBuilder{T}, TimeSpan)"/>./// </summary>publicclassCachedEntityListSpecification:Specification<Entity>{publicCachedEntityListSpecification(stringcolor){Query.EnableCache(nameof(CachedEntityListSpecification),"filter_color",color).WithCacheExpiration(TimeSpan.FromHours(12)).Where(x =>x.Color==color);}}/// <summary>/// Example Entity class./// </summary>publicclassEntity{publicstringName{get;set;}publicstringColor{get;set;}}/// <summary>/// Example Repository/// </summary>publicclassRepository<T>{privateDbContext_ctx;privateMemoryCache_cache;publicList<T>List(ISpecification<T>spec){varspecificationResult=SpecificationEvaluator.Default.GetQuery(_ctx.Set<T>().AsQueryable(),spec);if(spec.CacheEnabled){varttl=CachedSpecificationExtensions.GetTimeSpan(spec.CacheKey);_cache.GetOrCreate(spec.CacheKey, ce =>{ce.AbsoluteExpiration=DateTime.Now.Add(ttl);returnspecificationResult.ToList();});}else{returnspecificationResult.ToList();}}}

[fiseni]

Hi @vittorelli,

Thank you. I do like this. We're not including anything specific, but we're providing a mechanism for users to handle it by themselves.

Your usage is nice too. To be honest, keeping app-wide mutable shared state is always fishy :) Yea, the concurrent dictionary is considered thread-safe, but not all methods. Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

@ardalis if you don't have any comments, let's merge this.

[vittorelli]

Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

Don't know why I didn't think of that. Way better, thanks! :-)

[ardalis]

I love it; let's do it! Any chance we can get a docs PR with some usage examples, too?

[vittorelli]

I'll see what I can do about the docs :-)

[vittorelli]

A small change to the SpecificationBuilderExtensions.EnableCache builder method in order to allow developers to create their own extension methods for customized caching implementations.

I've been using Spefications throughout several different projects and am a huge fan. We've recently added support for caching in our repositories and I've refactored the code so it integrates with Specification. A requirement in our project was to have some expiration date on the cache, which isn't possible with the current method signatures. I saw two possibilities:

1. Create additional methods/overloads/... in Ardalis.Specification that allow for adding information on how the caching should behave.
2. Minimal intrusion in Ardalis.Specification by changing the return type of SpecificationBuilderExtensions.EnableCache.

The liked the first option better, but soon realised that my requirements wouldn't nessecarily match those of other developers, and I didn't like the idea of creating too many new methods to support different needs in caching behaviour (absolute expiration, sliding windows, tokens, ....).

So I've gone with the second possibility.
The main idea of this pull request is to constrain the usage of extension methods one may create to facilitate custom caching needs in projects that consume Ardalis.Specification. This idea might also be extended to other builder methods.

What do you guys think?

Example on how I'm using the ICacheSpecificationBuilder

publicstaticclassCachedSpecificationExtensions{privatestaticConcurrentDictionary<string,TimeSpan>_expirationTimeSpans=new();/// <summary>/// Extension method which registers cache TTL values for the <see cref="Ardalis.Specification"/> on/// which this method is called./// </summary>publicstaticISpecificationBuilder<T>WithCacheExpiration<T>(thisICacheSpecificationBuilder<T>@this,TimeSpanspan)whereT:class{_expirationTimeSpans[@this.Specification.CacheKey]=span;return@this;}/// <summary>/// Utility method which can be used in repositories to read registered TTL values./// </summary>/// <param name="key"></param>publicstaticTimeSpanGetTimeSpan(stringkey){return_expirationTimeSpans.ContainsKey(key)?_expirationTimeSpans[key]:TimeSpan.MaxValue;}}/// <summary>/// Example specification using <see cref="SpecificationExtentions.WithCacheExpiration{T}(ICacheSpecificationBuilder{T}, TimeSpan)"/>./// </summary>publicclassCachedEntityListSpecification:Specification<Entity>{publicCachedEntityListSpecification(stringcolor){Query.EnableCache(nameof(CachedEntityListSpecification),"filter_color",color).WithCacheExpiration(TimeSpan.FromHours(12)).Where(x =>x.Color==color);}}/// <summary>/// Example Entity class./// </summary>publicclassEntity{publicstringName{get;set;}publicstringColor{get;set;}}/// <summary>/// Example Repository/// </summary>publicclassRepository<T>{privateDbContext_ctx;privateMemoryCache_cache;publicList<T>List(ISpecification<T>spec){varspecificationResult=SpecificationEvaluator.Default.GetQuery(_ctx.Set<T>().AsQueryable(),spec);if(spec.CacheEnabled){varttl=CachedSpecificationExtensions.GetTimeSpan(spec.CacheKey);_cache.GetOrCreate(spec.CacheKey, ce =>{ce.AbsoluteExpiration=DateTime.Now.Add(ttl);returnspecificationResult.ToList();});}else{returnspecificationResult.ToList();}}}

[fiseni]

Hi @vittorelli,

Thank you. I do like this. We're not including anything specific, but we're providing a mechanism for users to handle it by themselves.

Your usage is nice too. To be honest, keeping app-wide mutable shared state is always fishy :) Yea, the concurrent dictionary is considered thread-safe, but not all methods. Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

@ardalis if you don't have any comments, let's merge this.

[vittorelli]

Having your own base specification which will include the state might be a better solution, but it requires a bit more work.

Don't know why I didn't think of that. Way better, thanks! :-)

[ardalis]

I love it; let's do it! Any chance we can get a docs PR with some usage examples, too?

[vittorelli]

I'll see what I can do about the docs :-)