Refactor specification expressions

[devbased]

Closes#182.

[fiseni]

Thanks @devbased, it looks great.

Now that we refactored the types in ISpecification, can you please revise the evaluators in the plugin packages (EFCore and EF6) too? For instance, we might not need the Select here. You can refactor the input of the Search extension method too. There is Order evaluator in EF6 too.

namespaceArdalis.Specification.EntityFrameworkCore{publicclassSearchEvaluator:IEvaluator{privateSearchEvaluator(){}publicstaticSearchEvaluatorInstance{get;}=newSearchEvaluator();publicboolIsCriteriaEvaluator{get;}=true;publicIQueryable<T>GetQuery<T>(IQueryable<T>query,ISpecification<T>specification)whereT:class{foreach(varsearchCriteriainspecification.SearchCriterias.GroupBy(x =>x.SearchGroup)){varcriterias=searchCriteria.Select(x =>(x.Selector,x.SearchTerm));query=query.Search(criterias);}returnquery;}}}

[fiseni]

Ok, Steve was faster than me :) My bad, I noticed these details after approving the PR.
@devbased would you like to make those changes in an additional PR?

[ardalis]

Sorry! I was going to just approve but then thought "why should I make Fati have to come back and merge it..."

[fiseni]

No big deal. Everything works, it's more of cleanup work. We can do it in an additional PR.

[devbased]

Closes#182.

[fiseni]

Thanks @devbased, it looks great.

Now that we refactored the types in ISpecification, can you please revise the evaluators in the plugin packages (EFCore and EF6) too? For instance, we might not need the Select here. You can refactor the input of the Search extension method too. There is Order evaluator in EF6 too.

namespaceArdalis.Specification.EntityFrameworkCore{publicclassSearchEvaluator:IEvaluator{privateSearchEvaluator(){}publicstaticSearchEvaluatorInstance{get;}=newSearchEvaluator();publicboolIsCriteriaEvaluator{get;}=true;publicIQueryable<T>GetQuery<T>(IQueryable<T>query,ISpecification<T>specification)whereT:class{foreach(varsearchCriteriainspecification.SearchCriterias.GroupBy(x =>x.SearchGroup)){varcriterias=searchCriteria.Select(x =>(x.Selector,x.SearchTerm));query=query.Search(criterias);}returnquery;}}}

[fiseni]

Ok, Steve was faster than me :) My bad, I noticed these details after approving the PR.
@devbased would you like to make those changes in an additional PR?

[ardalis]

Sorry! I was going to just approve but then thought "why should I make Fati have to come back and merge it..."

[fiseni]

No big deal. Everything works, it's more of cleanup work. We can do it in an additional PR.

[devbased]

Closes#182.

[fiseni]

Thanks @devbased, it looks great.

Now that we refactored the types in ISpecification, can you please revise the evaluators in the plugin packages (EFCore and EF6) too? For instance, we might not need the Select here. You can refactor the input of the Search extension method too. There is Order evaluator in EF6 too.

namespaceArdalis.Specification.EntityFrameworkCore{publicclassSearchEvaluator:IEvaluator{privateSearchEvaluator(){}publicstaticSearchEvaluatorInstance{get;}=newSearchEvaluator();publicboolIsCriteriaEvaluator{get;}=true;publicIQueryable<T>GetQuery<T>(IQueryable<T>query,ISpecification<T>specification)whereT:class{foreach(varsearchCriteriainspecification.SearchCriterias.GroupBy(x =>x.SearchGroup)){varcriterias=searchCriteria.Select(x =>(x.Selector,x.SearchTerm));query=query.Search(criterias);}returnquery;}}}

[fiseni]

Ok, Steve was faster than me :) My bad, I noticed these details after approving the PR.
@devbased would you like to make those changes in an additional PR?

[ardalis]

Sorry! I was going to just approve but then thought "why should I make Fati have to come back and merge it..."

[fiseni]

No big deal. Everything works, it's more of cleanup work. We can do it in an additional PR.

[devbased]

Closes#182.

[fiseni]

Thanks @devbased, it looks great.

Now that we refactored the types in ISpecification, can you please revise the evaluators in the plugin packages (EFCore and EF6) too? For instance, we might not need the Select here. You can refactor the input of the Search extension method too. There is Order evaluator in EF6 too.

namespaceArdalis.Specification.EntityFrameworkCore{publicclassSearchEvaluator:IEvaluator{privateSearchEvaluator(){}publicstaticSearchEvaluatorInstance{get;}=newSearchEvaluator();publicboolIsCriteriaEvaluator{get;}=true;publicIQueryable<T>GetQuery<T>(IQueryable<T>query,ISpecification<T>specification)whereT:class{foreach(varsearchCriteriainspecification.SearchCriterias.GroupBy(x =>x.SearchGroup)){varcriterias=searchCriteria.Select(x =>(x.Selector,x.SearchTerm));query=query.Search(criterias);}returnquery;}}}

[fiseni]

Ok, Steve was faster than me :) My bad, I noticed these details after approving the PR.
@devbased would you like to make those changes in an additional PR?

[ardalis]

Sorry! I was going to just approve but then thought "why should I make Fati have to come back and merge it..."

[fiseni]

No big deal. Everything works, it's more of cleanup work. We can do it in an additional PR.

[devbased]

Closes#182.

[fiseni]

Thanks @devbased, it looks great.

Now that we refactored the types in ISpecification, can you please revise the evaluators in the plugin packages (EFCore and EF6) too? For instance, we might not need the Select here. You can refactor the input of the Search extension method too. There is Order evaluator in EF6 too.

namespaceArdalis.Specification.EntityFrameworkCore{publicclassSearchEvaluator:IEvaluator{privateSearchEvaluator(){}publicstaticSearchEvaluatorInstance{get;}=newSearchEvaluator();publicboolIsCriteriaEvaluator{get;}=true;publicIQueryable<T>GetQuery<T>(IQueryable<T>query,ISpecification<T>specification)whereT:class{foreach(varsearchCriteriainspecification.SearchCriterias.GroupBy(x =>x.SearchGroup)){varcriterias=searchCriteria.Select(x =>(x.Selector,x.SearchTerm));query=query.Search(criterias);}returnquery;}}}

[fiseni]

Ok, Steve was faster than me :) My bad, I noticed these details after approving the PR.
@devbased would you like to make those changes in an additional PR?

[ardalis]

Sorry! I was going to just approve but then thought "why should I make Fati have to come back and merge it..."

[fiseni]

No big deal. Everything works, it's more of cleanup work. We can do it in an additional PR.

[devbased]

Closes#182.

[fiseni]

Thanks @devbased, it looks great.

Now that we refactored the types in ISpecification, can you please revise the evaluators in the plugin packages (EFCore and EF6) too? For instance, we might not need the Select here. You can refactor the input of the Search extension method too. There is Order evaluator in EF6 too.

namespaceArdalis.Specification.EntityFrameworkCore{publicclassSearchEvaluator:IEvaluator{privateSearchEvaluator(){}publicstaticSearchEvaluatorInstance{get;}=newSearchEvaluator();publicboolIsCriteriaEvaluator{get;}=true;publicIQueryable<T>GetQuery<T>(IQueryable<T>query,ISpecification<T>specification)whereT:class{foreach(varsearchCriteriainspecification.SearchCriterias.GroupBy(x =>x.SearchGroup)){varcriterias=searchCriteria.Select(x =>(x.Selector,x.SearchTerm));query=query.Search(criterias);}returnquery;}}}

[fiseni]

Ok, Steve was faster than me :) My bad, I noticed these details after approving the PR.
@devbased would you like to make those changes in an additional PR?

[ardalis]

Sorry! I was going to just approve but then thought "why should I make Fati have to come back and merge it..."

[fiseni]

No big deal. Everything works, it's more of cleanup work. We can do it in an additional PR.

[devbased]

Closes#182.

[fiseni]

Thanks @devbased, it looks great.

Now that we refactored the types in ISpecification, can you please revise the evaluators in the plugin packages (EFCore and EF6) too? For instance, we might not need the Select here. You can refactor the input of the Search extension method too. There is Order evaluator in EF6 too.

namespaceArdalis.Specification.EntityFrameworkCore{publicclassSearchEvaluator:IEvaluator{privateSearchEvaluator(){}publicstaticSearchEvaluatorInstance{get;}=newSearchEvaluator();publicboolIsCriteriaEvaluator{get;}=true;publicIQueryable<T>GetQuery<T>(IQueryable<T>query,ISpecification<T>specification)whereT:class{foreach(varsearchCriteriainspecification.SearchCriterias.GroupBy(x =>x.SearchGroup)){varcriterias=searchCriteria.Select(x =>(x.Selector,x.SearchTerm));query=query.Search(criterias);}returnquery;}}}

[fiseni]

Ok, Steve was faster than me :) My bad, I noticed these details after approving the PR.
@devbased would you like to make those changes in an additional PR?

[ardalis]

Sorry! I was going to just approve but then thought "why should I make Fati have to come back and merge it..."

[fiseni]

No big deal. Everything works, it's more of cleanup work. We can do it in an additional PR.

[devbased]

Closes#182.

[fiseni]

Thanks @devbased, it looks great.

Now that we refactored the types in ISpecification, can you please revise the evaluators in the plugin packages (EFCore and EF6) too? For instance, we might not need the Select here. You can refactor the input of the Search extension method too. There is Order evaluator in EF6 too.

namespaceArdalis.Specification.EntityFrameworkCore{publicclassSearchEvaluator:IEvaluator{privateSearchEvaluator(){}publicstaticSearchEvaluatorInstance{get;}=newSearchEvaluator();publicboolIsCriteriaEvaluator{get;}=true;publicIQueryable<T>GetQuery<T>(IQueryable<T>query,ISpecification<T>specification)whereT:class{foreach(varsearchCriteriainspecification.SearchCriterias.GroupBy(x =>x.SearchGroup)){varcriterias=searchCriteria.Select(x =>(x.Selector,x.SearchTerm));query=query.Search(criterias);}returnquery;}}}

[fiseni]

Ok, Steve was faster than me :) My bad, I noticed these details after approving the PR.
@devbased would you like to make those changes in an additional PR?

[ardalis]

Sorry! I was going to just approve but then thought "why should I make Fati have to come back and merge it..."

[fiseni]

No big deal. Everything works, it's more of cleanup work. We can do it in an additional PR.