Skip to content

Update state on connect - #128

Open
episource wants to merge 1 commit into
arduino-libraries:masterfrom
episource:feature/update-state-on-connect
Open

Update state on connect#128
episource wants to merge 1 commit into
arduino-libraries:masterfrom
episource:feature/update-state-on-connect

Conversation

@episource

Copy link
Copy Markdown

HttpClient implements inherited Client::connect(IPAddress ip, uint16_t port) and Client::connect(const char *host, uint16_t port). The existing implementation is to simple: it does not update internal state variables iServerName, iServerAddressand iServerPort, but just invokes the wrapped client. This causes subsequent requests to be incorrect (e.g. wrong host header).

This PR changes connect to also update state.

@github-actions

Copy link
Copy Markdown

Memory usage change @ 967f1bb

Boardflash%RAM for global variables%
arduino:samd:mkr1000🔺 +24 - +32+0.01 - +0.010 - 00.0 - 0.0
Click for full report table
Boardexamples/BasicAuthGet
flash
%examples/BasicAuthGet
RAM for global variables
%examples/CustomHeader
flash
%examples/CustomHeader
RAM for global variables
%examples/DweetGet
flash
%examples/DweetGet
RAM for global variables
%examples/DweetPost
flash
%examples/DweetPost
RAM for global variables
%examples/HueBlink
flash
%examples/HueBlink
RAM for global variables
%examples/PostWithHeaders
flash
%examples/PostWithHeaders
RAM for global variables
%examples/SimpleDelete
flash
%examples/SimpleDelete
RAM for global variables
%examples/SimpleGet
flash
%examples/SimpleGet
RAM for global variables
%examples/SimpleHttpExample
flash
%examples/SimpleHttpExample
RAM for global variables
%examples/SimplePost
flash
%examples/SimplePost
RAM for global variables
%examples/SimplePut
flash
%examples/SimplePut
RAM for global variables
%examples/SimpleWebSocket
flash
%examples/SimpleWebSocket
RAM for global variables
%
arduino:samd:mkr1000320.0100.0320.0100.0240.0100.0240.0100.0320.0100.0320.0100.0240.0100.0320.0100.0320.0100.0320.0100.0320.0100.0320.0100.0
Click for full report CSV
Board,examples/BasicAuthGet<br>flash,%,examples/BasicAuthGet<br>RAM for global variables,%,examples/CustomHeader<br>flash,%,examples/CustomHeader<br>RAM for global variables,%,examples/DweetGet<br>flash,%,examples/DweetGet<br>RAM for global variables,%,examples/DweetPost<br>flash,%,examples/DweetPost<br>RAM for global variables,%,examples/HueBlink<br>flash,%,examples/HueBlink<br>RAM for global variables,%,examples/PostWithHeaders<br>flash,%,examples/PostWithHeaders<br>RAM for global variables,%,examples/SimpleDelete<br>flash,%,examples/SimpleDelete<br>RAM for global variables,%,examples/SimpleGet<br>flash,%,examples/SimpleGet<br>RAM for global variables,%,examples/SimpleHttpExample<br>flash,%,examples/SimpleHttpExample<br>RAM for global variables,%,examples/SimplePost<br>flash,%,examples/SimplePost<br>RAM for global variables,%,examples/SimplePut<br>flash,%,examples/SimplePut<br>RAM for global variables,%,examples/SimpleWebSocket<br>flash,%,examples/SimpleWebSocket<br>RAM for global variables,%
arduino:samd:mkr1000,32,0.01,0,0.0,32,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,24,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0

@per1234per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Mar 21, 2022
@matiasba

Copy link
Copy Markdown

@per1234 any chance we can merge this pull request? it seems very useful, as the current implementation fails when making multiples request.

@CLAassistant

CLAassistant commented Apr 4, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: codeRelated to content of the project itselftype: imperfectionPerceived defect in any part of project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@episource@matiasba@CLAassistant@per1234