Skip to content

emrg: gui renderer Batch 5 cleanup — delete vanilla renderer + legacy vm.runInContext tests - #1024

Merged
argszero merged 2 commits into
masterfrom
feature/renderer-vanilla-cleanup
Aug 26, 2026
Merged

emrg: gui renderer Batch 5 cleanup — delete vanilla renderer + legacy vm.runInContext tests#1024
argszero merged 2 commits into
masterfrom
feature/renderer-vanilla-cleanup

Conversation

@argszero

Copy link
Copy Markdown
Owner

Batch 5 final cleanup (design doc D6): remove the now-inert vanilla renderer after #1023 switched main.js to load the React dist.

Changes:

  • Delete vanilla renderer: renderer/js/.js (12 files), renderer/css/.css (5 files), renderer/index.html — all superseded by the React app (main.js loads renderer/dist since emrg: gui renderer Batch 5 final switch — main.js loads React renderer dist #1023).
  • Delete legacy vm.runInContext tests that pinned the vanilla JS: renderer.smoke.test.js (132), i18n.test.js (15), commands.test.js (3), tool-group.test.js (2), app-commands.test.js (22). Their coverage lives in the React vitest suite (411 tests) + GUI suite.
  • build-config.test.js: drop 2 tests that read the deleted vanilla markdown.js / index.html (AMD-hijack script-order guard — the vanilla script-tag page no longer exists; React bundles marked/dompurify/highlight via npm, no AMD race).
  • test_upgrade.py: remove deleted renderer files from the no-residual-references list.
  • test.yml: GUI syntax check no longer scans renderer/js (React source is tsc-checked in the renderer step).
  • Docs: Agent.md + DEVELOPMENT.md GUI test counts 265 -> 89 (45 daemon_client + 20 conn-manager + 8 integration + 6 build-config + 7 gui-state + 3 preload-api).

Verification:

  • GUI npm test: 89 (81 pass + 8 skip, 0 fail)
  • Renderer: typecheck OK + vitest 411 pass + vite build -> dist OK
  • pytest: 1106 passed + 1 skipped; doc-count guard 4/4; import + CLI OK
  • actionlint: all workflows pass (test.yml edited)

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 2026-08-27T04:11:16

Independent review of head e0cf1ea (full 28-file diff):

  • Deletes the now-inert vanilla renderer (renderer/js ×12, renderer/css ×5, index.html) — main.js has loaded renderer/dist since #1023; verified vite entry is src/index.html, fully independent.
  • Deletes 5 legacy vm.runInContext test files (174 tests pinning dead code) — their coverage lives in the React vitest suite (411) + GUI suite.
  • build-config.test.js: removes 2 tests that read the deleted vanilla markdown.js/index.html (AMD-hijack script-order guard is obsolete — React bundles marked/dompurify/highlight via npm, no AMD race; vendored monaco is no longer consumed by any runtime path).
  • test.yml: syntax-check loop for renderer/js removed; React source is tsc-checked in the renderer step. actionlint clean.
  • test_upgrade.py + Agent.md/DEVELOPMENT.md: residual-reference list and GUI counts (265→89) updated; doc-count guard passes 4/4.
  • Review found + fixed a doc nit: Agent.md Batch 5 bullet said 'GUI 91' while the real count is 89 (e0cf1ea).
    CI run 33009223480: test 1m49s + test-windows 1m4s, both SUCCESS. Local: GUI 89 (81 pass/8 skip), renderer 411, pytest 1106+1, doc-count 4/4, import+CLI OK. mergeable: MERGEABLE / CLEAN.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 2026-08-27T04:20:53

Second independent review (LGTM 2/3). Head e0cf1ea unchanged since previous vote (rev-parse confirmed). Re-verified branch state: Agent.md GUI counts 89/89 on both lines; no dangling references to the deleted vanilla renderer paths anywhere in code/CI/docs (only benign session-history mentions + a whitelist-comment); diff vs master = 28 files, -14355/+6 (pure deletion + doc/CI cleanup). Local: doc-count 4/4, GUI 89 (81 pass/8 skip), renderer vitest 411. CI run 33009223480: test 1m49s + test-windows 1m4s both SUCCESS. mergeable: MERGEABLE / CLEAN.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 2026-08-27T04:27:33

Third independent review. Verified: head e0cf1ea unchanged, CI double-green (test + test-windows, run 33009223480), local checks pass (pytest 1106 passed + 1 skipped, GUI 89 tests, renderer vitest 411/411 + typecheck + build OK, doc-count guard 4/4). Clean deletion of the vanilla renderer and legacy tests — no issues found.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@argszero